From: Jason Gunthorpe <jgg@ziepe.ca>
To: Gal Pressman <galpress@amazon.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/nldev: Add parent bdf to device information dump
Date: Tue, 10 Nov 2020 09:41:22 -0400 [thread overview]
Message-ID: <20201110134122.GL244516@ziepe.ca> (raw)
In-Reply-To: <6c77ad03-db3b-a1f8-cd28-a744585ba26d@amazon.com>
On Tue, Nov 10, 2020 at 09:49:11AM +0200, Gal Pressman wrote:
> On 09/11/2020 19:57, Jason Gunthorpe wrote:
> > On Mon, Nov 09, 2020 at 11:03:47AM +0200, Gal Pressman wrote:
> >
> >>> The thing is, is is still useless. You have to consult sysfs to
> >>> understand what bus it is scoped on to do anything further with
> >>> it. Can't just assume it is PCI.
> >>
> >> This can be solved with Parav's suggestion.
> >
> > Now you are adding more stuff.
> >
> > What is wrong with reading sysfs? sysfs is where topology information
> > lives, why do we need to denormalize things?
>
> And yet you have lspci so you don't have to dig through the sysfs files by hand
> for that topology.
> Please drop this patch.
If you want to add something to rdma tool it can read sysfs and disply it
Jason
next prev parent reply other threads:[~2020-11-10 13:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:26 [PATCH for-next] RDMA/nldev: Add parent bdf to device information dump Gal Pressman
2020-11-03 13:31 ` Parav Pandit
2020-11-03 13:45 ` Jason Gunthorpe
2020-11-03 13:57 ` Leon Romanovsky
2020-11-03 14:11 ` Gal Pressman
2020-11-03 14:22 ` Jason Gunthorpe
2020-11-03 15:45 ` Gal Pressman
2020-11-05 20:00 ` Jason Gunthorpe
2020-11-08 13:03 ` Gal Pressman
2020-11-08 14:36 ` Parav Pandit
2020-11-08 23:49 ` Jason Gunthorpe
2020-11-09 5:09 ` Leon Romanovsky
2020-11-09 9:03 ` Gal Pressman
2020-11-09 11:55 ` Leon Romanovsky
2020-11-09 12:27 ` Gal Pressman
2020-11-09 12:32 ` Leon Romanovsky
2020-11-09 12:47 ` Gal Pressman
2020-11-09 13:02 ` Leon Romanovsky
2020-11-09 13:52 ` Gal Pressman
2020-11-09 14:12 ` Leon Romanovsky
2020-11-09 9:03 ` Gal Pressman
2020-11-09 17:57 ` Jason Gunthorpe
2020-11-10 7:49 ` Gal Pressman
2020-11-10 13:41 ` Jason Gunthorpe [this message]
2020-11-10 13:54 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110134122.GL244516@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox