* [PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic_init()
@ 2020-11-14 11:52 Wang Hai
2020-11-16 20:05 ` Saeed Mahameed
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-11-14 11:52 UTC (permalink / raw)
To: saeedm, leon, davem, kuba, lariel, roid; +Cc: linux-rdma, netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic flows")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index e3a968e9e2a0..c7ad5db84f78 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -5227,8 +5227,10 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv)
tc->ct = mlx5_tc_ct_init(priv, tc->chains, &priv->fs.tc.mod_hdr,
MLX5_FLOW_NAMESPACE_KERNEL);
- if (IS_ERR(tc->ct))
+ if (IS_ERR(tc->ct)) {
+ err = PTR_ERR(tc->ct);
goto err_ct;
+ }
tc->netdevice_nb.notifier_call = mlx5e_tc_netdev_event;
err = register_netdevice_notifier_dev_net(priv->netdev,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic_init()
2020-11-14 11:52 [PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic_init() Wang Hai
@ 2020-11-16 20:05 ` Saeed Mahameed
0 siblings, 0 replies; 2+ messages in thread
From: Saeed Mahameed @ 2020-11-16 20:05 UTC (permalink / raw)
To: Wang Hai, leon, davem, kuba, lariel, roid
Cc: linux-rdma, netdev, linux-kernel
On Sat, 2020-11-14 at 19:52 +0800, Wang Hai wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic
> flows")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index e3a968e9e2a0..c7ad5db84f78 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -5227,8 +5227,10 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv)
>
> tc->ct = mlx5_tc_ct_init(priv, tc->chains, &priv-
> >fs.tc.mod_hdr,
> MLX5_FLOW_NAMESPACE_KERNEL);
> - if (IS_ERR(tc->ct))
> + if (IS_ERR(tc->ct)) {
> + err = PTR_ERR(tc->ct);
> goto err_ct;
> + }
>
> tc->netdevice_nb.notifier_call = mlx5e_tc_netdev_event;
> err = register_netdevice_notifier_dev_net(priv->netdev,
Applied to net-mlx5
Thanks !
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-14 11:52 [PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic_init() Wang Hai
2020-11-16 20:05 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox