From: Leon Romanovsky <leon@kernel.org>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-core] librdmacm: Make rdma_create_qp_ex() report proper errno
Date: Wed, 16 Dec 2020 10:21:58 +0200 [thread overview]
Message-ID: <20201216082158.GA1060282@unreal> (raw)
In-Reply-To: <20201216015459.78733-1-yangx.jy@cn.fujitsu.com>
On Wed, Dec 16, 2020 at 09:54:59AM +0800, Xiao Yang wrote:
> Current rdma_create_qp_ex() reports fixed ENOMEM when calling
> ibv_create_qp_ex() fails, so it's hard for user to know which
> actual error happens on ibv_create_qp_ex().
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> librdmacm/cma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The same change should be done for the ibv_alloc_pd() call.
635 if (!cma_dev->pd)
636 cma_dev->pd = ibv_alloc_pd(cma_dev->verbs);
637 if (!cma_dev->pd) {
638 ret = ERR(ENOMEM);
639 goto out;
640 }
And please add Fixes line.
Thanks
prev parent reply other threads:[~2020-12-16 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 1:54 [PATCH rdma-core] librdmacm: Make rdma_create_qp_ex() report proper errno Xiao Yang
2020-12-16 8:21 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216082158.GA1060282@unreal \
--to=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox