Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org
Subject: [PATCH 09/30] RDMA/hw/qib/qib_mad: Fix a few misspellings and supply missing descriptions
Date: Thu, 21 Jan 2021 09:44:58 +0000	[thread overview]
Message-ID: <20210121094519.2044049-10-lee.jones@linaro.org> (raw)
In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/infiniband/hw/qib/qib_mad.c:896: warning: Function parameter or member 'ppd' not described in 'rm_pkey'
 drivers/infiniband/hw/qib/qib_mad.c:896: warning: Excess function parameter 'dd' description in 'rm_pkey'
 drivers/infiniband/hw/qib/qib_mad.c:926: warning: Function parameter or member 'ppd' not described in 'add_pkey'
 drivers/infiniband/hw/qib/qib_mad.c:926: warning: Excess function parameter 'dd' description in 'add_pkey'
 drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'in' not described in 'qib_process_mad'
 drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out' not described in 'qib_process_mad'
 drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out_mad_size' not described in 'qib_process_mad'
 drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out_mad_pkey_index' not described in 'qib_process_mad'
 drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Excess function parameter 'in_mad' description in 'qib_process_mad'
 drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Excess function parameter 'out_mad' description in 'qib_process_mad'

Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/infiniband/hw/qib/qib_mad.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index f83e331977f82..44e2f813024a6 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -886,7 +886,7 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
 
 /**
  * rm_pkey - decrecment the reference count for the given PKEY
- * @dd: the qlogic_ib device
+ * @ppd: the qlogic_ib device
  * @key: the PKEY index
  *
  * Return true if this was the last reference and the hardware table entry
@@ -916,7 +916,7 @@ static int rm_pkey(struct qib_pportdata *ppd, u16 key)
 
 /**
  * add_pkey - add the given PKEY to the hardware table
- * @dd: the qlogic_ib device
+ * @ppd: the qlogic_ib device
  * @key: the PKEY
  *
  * Return an error code if unable to add the entry, zero if no change,
@@ -2346,8 +2346,10 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
  * @port: the port number this packet came in on
  * @in_wc: the work completion entry for this packet
  * @in_grh: the global route header for this packet
- * @in_mad: the incoming MAD
- * @out_mad: any outgoing MAD reply
+ * @in: the incoming MAD
+ * @out: any outgoing MAD reply
+ * @out_mad_size: size of the outgoing MAD reply
+ * @out_mad_pkey_index: unused
  *
  * Returns IB_MAD_RESULT_SUCCESS if this is a MAD that we are not
  * interested in processing.
-- 
2.25.1


  parent reply	other threads:[~2021-01-21  9:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  9:44 [PATCH 00/30] [Set 2] Rid W=1 warnings from Infiniband Lee Jones
2021-01-21  9:44 ` [PATCH 01/30] RDMA/hw/mlx5/odp: Fix formatting and add missing descriptions in 'pagefault_data_segments()' Lee Jones
2021-01-21 17:47   ` Leon Romanovsky
2021-01-21  9:44 ` [PATCH 02/30] RDMA/hw/mlx5/qp: Demote non-conformant kernel-doc header Lee Jones
2021-01-21 17:47   ` Leon Romanovsky
2021-01-21  9:44 ` [PATCH 03/30] RDMA/hw/efa/efa_com: Stop using param description notation for non-params Lee Jones
2021-01-21 13:14   ` Gal Pressman
2021-01-21  9:44 ` [PATCH 04/30] RDMA/hw/hns/hns_roce_hw_v1: Fix doc-rot issue relating to 'rereset' Lee Jones
2021-01-21  9:44 ` [PATCH 05/30] RDMA/hw/hns/hns_roce_mr: Add missing description for 'hr_dev' param Lee Jones
2021-01-21  9:44 ` [PATCH 06/30] RDMA/hw/qib/qib_driver: Fix misspelling in 'ppd's param description Lee Jones
2021-01-21  9:44 ` [PATCH 07/30] RDMA/sw/rdmavt/vt: Fix formatting issue and update description for 'context' Lee Jones
2021-01-21  9:44 ` [PATCH 08/30] RDMA/hw/qib/qib_eeprom: Fix misspelling of 'buff' in 'qib_eeprom_{read,write}()' Lee Jones
2021-01-21  9:44 ` Lee Jones [this message]
2021-01-21  9:44 ` [PATCH 10/30] RDMA/hw/qib/qib_intr: Fix a bunch of formatting issues Lee Jones
2021-01-21  9:45 ` [PATCH 11/30] RDMA/hw/qib/qib_pcie: Demote obvious kernel-doc abuse Lee Jones
2021-01-21  9:45 ` [PATCH 12/30] RDMA/hw/qib/qib_qp: Fix some issues in worthy kernel-doc headers and demote another Lee Jones
2021-01-21  9:45 ` [PATCH 13/30] RDMA/sw/rdmavt/cq: Demote hardly complete kernel-doc header Lee Jones
2021-01-21  9:45 ` [PATCH 14/30] RDMA/hw/qib/qib_rc: Fix some worthy kernel-docs demote hardly complete one Lee Jones
2021-01-21  9:45 ` [PATCH 15/30] RDMA/hw/hfi1/chip: Fix a bunch of kernel-doc formatting and spelling issues Lee Jones
2021-01-21  9:45 ` [PATCH 16/30] RDMA/hw/qib/qib_twsi: Provide description for missing param 'last' Lee Jones
2021-01-21  9:45 ` [PATCH 17/30] RDMA/hw/qib/qib_tx: Provide description for 'qib_chg_pioavailkernel()'s 'rcd' param Lee Jones
2021-01-21  9:45 ` [PATCH 18/30] RDMA/hw/qib/qib_uc: Provide description for missing 'flags' param Lee Jones
2021-01-21  9:45 ` [PATCH 19/30] RDMA/hw/qib/qib_ud: Provide description for 'qib_make_ud_req's " Lee Jones
2021-01-21  9:45 ` [PATCH 20/30] RDMA/sw/rdmavt/mad: Fix 'rvt_process_mad()'s documentation header Lee Jones
2021-01-21  9:45 ` [PATCH 21/30] RDMA/hw/qib/qib_user_pages: Demote non-conformant " Lee Jones
2021-01-21  9:45 ` [PATCH 22/30] RDMA/sw/rdmavt/mcast: Demote incomplete kernel-doc header Lee Jones
2021-01-21  9:45 ` [PATCH 23/30] RDMA/hw/hfi1/exp_rcv: Fix some kernel-doc formatting issues Lee Jones
2021-01-21  9:45 ` [PATCH 24/30] RDMA/hw/qib/qib_iba7220: Fix some kernel-doc issues Lee Jones
2021-01-21  9:45 ` [PATCH 25/30] RDMA/hw/hfi1/file_ops: Fix' manage_rcvq()'s 'arg' param Lee Jones
2021-01-21  9:45 ` [PATCH 26/30] RDMA/sw/rdmavt/mr: Fix some issues related to formatting and missing descriptions Lee Jones
2021-01-21  9:45 ` [PATCH 27/30] RDMA/hw/qib/qib_iba7322: Fix a bunch of copy/paste issues Lee Jones
2021-01-21  9:45 ` [PATCH 28/30] RDMA/hw/qib/qib_verbs: Repair some formatting problems Lee Jones
2021-01-21  9:45 ` [PATCH 29/30] RDMA/hw/qib/qib_iba6120: Fix some repeated (copy/paste) kernel-doc issues Lee Jones
2021-01-21  9:45 ` [PATCH 30/30] RDMA/sw/rdmavt/qp: Fix a bunch of kernel-doc misdemeanours Lee Jones
2021-01-22 18:57 ` [PATCH 00/30] [Set 2] Rid W=1 warnings from Infiniband Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121094519.2044049-10-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@cornelisnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox