Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org
Subject: [PATCH 26/30] RDMA/sw/rdmavt/mr: Fix some issues related to formatting and missing descriptions
Date: Thu, 21 Jan 2021 09:45:15 +0000	[thread overview]
Message-ID: <20210121094519.2044049-27-lee.jones@linaro.org> (raw)
In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/infiniband/sw/rdmavt/mr.c:380: warning: Function parameter or member 'virt_addr' not described in 'rvt_reg_user_mr'
 drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'qp' not described in 'rvt_dereg_clean_qp_cb'
 drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'v' not described in 'rvt_dereg_clean_qp_cb'
 drivers/infiniband/sw/rdmavt/mr.c:466: warning: Function parameter or member 'mr' not described in 'rvt_dereg_clean_qps'
 drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 'mr' not described in 'rvt_check_refs'
 drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 't' not described in 'rvt_check_refs'
 drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'mr' not described in 'rvt_mr_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'lkey' not described in 'rvt_mr_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'ss' not described in 'rvt_ss_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'lkey' not described in 'rvt_ss_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:551: warning: Function parameter or member 'udata' not described in 'rvt_dereg_mr'

Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/infiniband/sw/rdmavt/mr.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/infiniband/sw/rdmavt/mr.c b/drivers/infiniband/sw/rdmavt/mr.c
index 90fc234f489ac..601d18dda1f5a 100644
--- a/drivers/infiniband/sw/rdmavt/mr.c
+++ b/drivers/infiniband/sw/rdmavt/mr.c
@@ -369,6 +369,7 @@ struct ib_mr *rvt_get_dma_mr(struct ib_pd *pd, int acc)
  * @pd: protection domain for this memory region
  * @start: starting userspace address
  * @length: length of region to register
+ * @virt_addr: associated virtual address
  * @mr_access_flags: access flags for this memory region
  * @udata: unused by the driver
  *
@@ -438,8 +439,8 @@ struct ib_mr *rvt_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,
 
 /**
  * rvt_dereg_clean_qp_cb - callback from iterator
- * @qp - the qp
- * @v - the mregion (as u64)
+ * @qp: the qp
+ * @v: the mregion (as u64)
  *
  * This routine fields the callback for all QPs and
  * for QPs in the same PD as the MR will call the
@@ -457,7 +458,7 @@ static void rvt_dereg_clean_qp_cb(struct rvt_qp *qp, u64 v)
 
 /**
  * rvt_dereg_clean_qps - find QPs for reference cleanup
- * @mr - the MR that is being deregistered
+ * @mr: the MR that is being deregistered
  *
  * This routine iterates RC QPs looking for references
  * to the lkey noted in mr.
@@ -471,8 +472,8 @@ static void rvt_dereg_clean_qps(struct rvt_mregion *mr)
 
 /**
  * rvt_check_refs - check references
- * @mr - the megion
- * @t - the caller identification
+ * @mr: the megion
+ * @t: the caller identification
  *
  * This routine checks MRs holding a reference during
  * when being de-registered.
@@ -506,8 +507,8 @@ static int rvt_check_refs(struct rvt_mregion *mr, const char *t)
 
 /**
  * rvt_mr_has_lkey - is MR
- * @mr - the mregion
- * @lkey - the lkey
+ * @mr: the mregion
+ * @lkey: the lkey
  */
 bool rvt_mr_has_lkey(struct rvt_mregion *mr, u32 lkey)
 {
@@ -516,8 +517,8 @@ bool rvt_mr_has_lkey(struct rvt_mregion *mr, u32 lkey)
 
 /**
  * rvt_ss_has_lkey - is mr in sge tests
- * @ss - the sge state
- * @lkey
+ * @ss: the sge state
+ * @lkey: the lkey
  *
  * This code tests for an MR in the indicated
  * sge state.
@@ -540,7 +541,7 @@ bool rvt_ss_has_lkey(struct rvt_sge_state *ss, u32 lkey)
 /**
  * rvt_dereg_mr - unregister and free a memory region
  * @ibmr: the memory region to free
- *
+ * @udata: unused by the driver
  *
  * Note that this is called to free MRs created by rvt_get_dma_mr()
  * or rvt_reg_user_mr().
-- 
2.25.1


  parent reply	other threads:[~2021-01-21 10:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  9:44 [PATCH 00/30] [Set 2] Rid W=1 warnings from Infiniband Lee Jones
2021-01-21  9:44 ` [PATCH 01/30] RDMA/hw/mlx5/odp: Fix formatting and add missing descriptions in 'pagefault_data_segments()' Lee Jones
2021-01-21 17:47   ` Leon Romanovsky
2021-01-21  9:44 ` [PATCH 02/30] RDMA/hw/mlx5/qp: Demote non-conformant kernel-doc header Lee Jones
2021-01-21 17:47   ` Leon Romanovsky
2021-01-21  9:44 ` [PATCH 03/30] RDMA/hw/efa/efa_com: Stop using param description notation for non-params Lee Jones
2021-01-21 13:14   ` Gal Pressman
2021-01-21  9:44 ` [PATCH 04/30] RDMA/hw/hns/hns_roce_hw_v1: Fix doc-rot issue relating to 'rereset' Lee Jones
2021-01-21  9:44 ` [PATCH 05/30] RDMA/hw/hns/hns_roce_mr: Add missing description for 'hr_dev' param Lee Jones
2021-01-21  9:44 ` [PATCH 06/30] RDMA/hw/qib/qib_driver: Fix misspelling in 'ppd's param description Lee Jones
2021-01-21  9:44 ` [PATCH 07/30] RDMA/sw/rdmavt/vt: Fix formatting issue and update description for 'context' Lee Jones
2021-01-21  9:44 ` [PATCH 08/30] RDMA/hw/qib/qib_eeprom: Fix misspelling of 'buff' in 'qib_eeprom_{read,write}()' Lee Jones
2021-01-21  9:44 ` [PATCH 09/30] RDMA/hw/qib/qib_mad: Fix a few misspellings and supply missing descriptions Lee Jones
2021-01-21  9:44 ` [PATCH 10/30] RDMA/hw/qib/qib_intr: Fix a bunch of formatting issues Lee Jones
2021-01-21  9:45 ` [PATCH 11/30] RDMA/hw/qib/qib_pcie: Demote obvious kernel-doc abuse Lee Jones
2021-01-21  9:45 ` [PATCH 12/30] RDMA/hw/qib/qib_qp: Fix some issues in worthy kernel-doc headers and demote another Lee Jones
2021-01-21  9:45 ` [PATCH 13/30] RDMA/sw/rdmavt/cq: Demote hardly complete kernel-doc header Lee Jones
2021-01-21  9:45 ` [PATCH 14/30] RDMA/hw/qib/qib_rc: Fix some worthy kernel-docs demote hardly complete one Lee Jones
2021-01-21  9:45 ` [PATCH 15/30] RDMA/hw/hfi1/chip: Fix a bunch of kernel-doc formatting and spelling issues Lee Jones
2021-01-21  9:45 ` [PATCH 16/30] RDMA/hw/qib/qib_twsi: Provide description for missing param 'last' Lee Jones
2021-01-21  9:45 ` [PATCH 17/30] RDMA/hw/qib/qib_tx: Provide description for 'qib_chg_pioavailkernel()'s 'rcd' param Lee Jones
2021-01-21  9:45 ` [PATCH 18/30] RDMA/hw/qib/qib_uc: Provide description for missing 'flags' param Lee Jones
2021-01-21  9:45 ` [PATCH 19/30] RDMA/hw/qib/qib_ud: Provide description for 'qib_make_ud_req's " Lee Jones
2021-01-21  9:45 ` [PATCH 20/30] RDMA/sw/rdmavt/mad: Fix 'rvt_process_mad()'s documentation header Lee Jones
2021-01-21  9:45 ` [PATCH 21/30] RDMA/hw/qib/qib_user_pages: Demote non-conformant " Lee Jones
2021-01-21  9:45 ` [PATCH 22/30] RDMA/sw/rdmavt/mcast: Demote incomplete kernel-doc header Lee Jones
2021-01-21  9:45 ` [PATCH 23/30] RDMA/hw/hfi1/exp_rcv: Fix some kernel-doc formatting issues Lee Jones
2021-01-21  9:45 ` [PATCH 24/30] RDMA/hw/qib/qib_iba7220: Fix some kernel-doc issues Lee Jones
2021-01-21  9:45 ` [PATCH 25/30] RDMA/hw/hfi1/file_ops: Fix' manage_rcvq()'s 'arg' param Lee Jones
2021-01-21  9:45 ` Lee Jones [this message]
2021-01-21  9:45 ` [PATCH 27/30] RDMA/hw/qib/qib_iba7322: Fix a bunch of copy/paste issues Lee Jones
2021-01-21  9:45 ` [PATCH 28/30] RDMA/hw/qib/qib_verbs: Repair some formatting problems Lee Jones
2021-01-21  9:45 ` [PATCH 29/30] RDMA/hw/qib/qib_iba6120: Fix some repeated (copy/paste) kernel-doc issues Lee Jones
2021-01-21  9:45 ` [PATCH 30/30] RDMA/sw/rdmavt/qp: Fix a bunch of kernel-doc misdemeanours Lee Jones
2021-01-22 18:57 ` [PATCH 00/30] [Set 2] Rid W=1 warnings from Infiniband Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121094519.2044049-27-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@cornelisnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox