* [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device
@ 2021-12-06 13:36 Wenpeng Liang
2021-12-06 15:37 ` Jason Gunthorpe
2021-12-06 23:52 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: Wenpeng Liang @ 2021-12-06 13:36 UTC (permalink / raw)
To: jgg, leon; +Cc: linux-rdma, linuxarm, liangwenpeng
From: Yixing Liu <liuyixing1@huawei.com>
It is more general for ARM device drivers to use the device attribute to
map pci bar spaces.
Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
---
drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index 8233bec053ee..a906c6078b72 100644
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -442,7 +442,7 @@ static int hns_roce_mmap(struct ib_ucontext *uctx, struct vm_area_struct *vma)
prot = vma->vm_page_prot;
if (entry->mmap_type != HNS_ROCE_MMAP_TYPE_TPTR)
- prot = pgprot_noncached(prot);
+ prot = pgprot_device(prot);
ret = rdma_user_mmap_io(uctx, vma, pfn, rdma_entry->npages * PAGE_SIZE,
prot, rdma_entry);
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device
2021-12-06 13:36 [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device Wenpeng Liang
@ 2021-12-06 15:37 ` Jason Gunthorpe
2021-12-07 12:51 ` Wenpeng Liang
2021-12-06 23:52 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2021-12-06 15:37 UTC (permalink / raw)
To: Wenpeng Liang; +Cc: leon, linux-rdma, linuxarm
On Mon, Dec 06, 2021 at 09:36:52PM +0800, Wenpeng Liang wrote:
> From: Yixing Liu <liuyixing1@huawei.com>
>
> It is more general for ARM device drivers to use the device attribute to
> map pci bar spaces.
>
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
It seems like the right thing todo, thanks
I see other drivers are doing it wrong as well:
drivers/infiniband/hw/bnxt_re/ib_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/cxgb4/provider.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/cxgb4/provider.c: pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/cxgb4/t4.h: return pgprot_noncached(prot);
drivers/infiniband/hw/efa/efa_verbs.c: pgprot_noncached(vma->vm_page_prot),
drivers/infiniband/hw/hfi1/file_ops.c: /* vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); */
drivers/infiniband/hw/hfi1/file_ops.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/hns/hns_roce_main.c: prot = pgprot_noncached(prot);
drivers/infiniband/hw/irdma/verbs.c: pgprot_noncached(vma->vm_page_prot), NULL);
drivers/infiniband/hw/irdma/verbs.c: pgprot_noncached(vma->vm_page_prot),
drivers/infiniband/hw/mlx4/main.c: pgprot_noncached(vma->vm_page_prot),
drivers/infiniband/hw/mlx4/main.c: PAGE_SIZE, pgprot_noncached(vma->vm_page_prot),
drivers/infiniband/hw/mlx5/main.c: prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/mlx5/main.c: prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/mlx5/main.c: pgprot_noncached(vma->vm_page_prot),
drivers/infiniband/hw/mthca/mthca_provider.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/qib/qib_file_ops.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/qib/qib_file_ops.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/usnic/usnic_ib_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
They should all use pgprot_device I think?
It is the same except on ARM where pgprot_device() is a bit faster
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device
2021-12-06 15:37 ` Jason Gunthorpe
@ 2021-12-07 12:51 ` Wenpeng Liang
0 siblings, 0 replies; 4+ messages in thread
From: Wenpeng Liang @ 2021-12-07 12:51 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: leon, linux-rdma, linuxarm
On 2021/12/6 23:37, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 09:36:52PM +0800, Wenpeng Liang wrote:
>> From: Yixing Liu <liuyixing1@huawei.com>
>>
>> It is more general for ARM device drivers to use the device attribute to
>> map pci bar spaces.
>>
>> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
>> Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
>> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
>> ---
>> drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> It seems like the right thing todo, thanks
>
> I see other drivers are doing it wrong as well:
>
> drivers/infiniband/hw/bnxt_re/ib_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/cxgb4/provider.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/cxgb4/provider.c: pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/cxgb4/t4.h: return pgprot_noncached(prot);
> drivers/infiniband/hw/efa/efa_verbs.c: pgprot_noncached(vma->vm_page_prot),
> drivers/infiniband/hw/hfi1/file_ops.c: /* vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); */
> drivers/infiniband/hw/hfi1/file_ops.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/hns/hns_roce_main.c: prot = pgprot_noncached(prot);
> drivers/infiniband/hw/irdma/verbs.c: pgprot_noncached(vma->vm_page_prot), NULL);
> drivers/infiniband/hw/irdma/verbs.c: pgprot_noncached(vma->vm_page_prot),
> drivers/infiniband/hw/mlx4/main.c: pgprot_noncached(vma->vm_page_prot),
> drivers/infiniband/hw/mlx4/main.c: PAGE_SIZE, pgprot_noncached(vma->vm_page_prot),
> drivers/infiniband/hw/mlx5/main.c: prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/mlx5/main.c: prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/mlx5/main.c: pgprot_noncached(vma->vm_page_prot),
> drivers/infiniband/hw/mthca/mthca_provider.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/qib/qib_file_ops.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/qib/qib_file_ops.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c: vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
>
> They should all use pgprot_device I think?
>
> It is the same except on ARM where pgprot_device() is a bit faster
>
> Jason
> .
>
I will submit a patch to fix these problems later.
Thanks
Wenpeng
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device
2021-12-06 13:36 [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device Wenpeng Liang
2021-12-06 15:37 ` Jason Gunthorpe
@ 2021-12-06 23:52 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2021-12-06 23:52 UTC (permalink / raw)
To: Wenpeng Liang; +Cc: leon, linux-rdma, linuxarm
On Mon, Dec 06, 2021 at 09:36:52PM +0800, Wenpeng Liang wrote:
> From: Yixing Liu <liuyixing1@huawei.com>
>
> It is more general for ARM device drivers to use the device attribute to
> map pci bar spaces.
>
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-07 12:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-06 13:36 [PATCH for-next] RDMA/hns: Modify the mapping attribute of doorbell to device Wenpeng Liang
2021-12-06 15:37 ` Jason Gunthorpe
2021-12-07 12:51 ` Wenpeng Liang
2021-12-06 23:52 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox