* [PATCH v2] RDMA/rxe: Generate a completion for unsupported/invalid opcode
@ 2022-04-10 11:35 Xiao Yang
2022-04-12 14:16 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Xiao Yang @ 2022-04-10 11:35 UTC (permalink / raw)
To: rpearsonhpe, leon, jgg; +Cc: linux-rdma, Xiao Yang
Current rxe_requester() doesn't generate a completion when processing an
unsupported/invalid opcode. If rxe driver doesn't support a new opcode
(e.g. RDMA Atomic Write) and RDMA library supports it, an application
using the new opcode can reproduce this issue. Fix the issue by calling
"goto err;".
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 5f7348b11268..e2659663b283 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -659,7 +659,7 @@ int rxe_requester(void *arg)
opcode = next_opcode(qp, wqe, wqe->wr.opcode);
if (unlikely(opcode < 0)) {
wqe->status = IB_WC_LOC_QP_OP_ERR;
- goto exit;
+ goto err;
}
mask = rxe_opcode[opcode].mask;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] RDMA/rxe: Generate a completion for unsupported/invalid opcode
2022-04-10 11:35 [PATCH v2] RDMA/rxe: Generate a completion for unsupported/invalid opcode Xiao Yang
@ 2022-04-12 14:16 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2022-04-12 14:16 UTC (permalink / raw)
To: Xiao Yang; +Cc: rpearsonhpe, leon, linux-rdma
On Sun, Apr 10, 2022 at 07:35:13PM +0800, Xiao Yang wrote:
> Current rxe_requester() doesn't generate a completion when processing an
> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
> using the new opcode can reproduce this issue. Fix the issue by calling
> "goto err;".
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-12 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-10 11:35 [PATCH v2] RDMA/rxe: Generate a completion for unsupported/invalid opcode Xiao Yang
2022-04-12 14:16 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox