From: Jason Gunthorpe <jgg@ziepe.ca>
To: haris iqbal <haris.phnx@gmail.com>
Cc: "Pearson, Robert B" <robert.pearson2@hpe.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"aleksei.marov@ionos.com" <aleksei.marov@ionos.com>,
"leon@kernel.org" <leon@kernel.org>,
"haris.iqbal@ionos.com" <haris.iqbal@ionos.com>,
"jinpu.wang@ionos.com" <jinpu.wang@ionos.com>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>
Subject: Re: [PATCH] RDMA/rxe: For invalidate compare keys according to the MR access
Date: Tue, 5 Jul 2022 10:59:59 -0300 [thread overview]
Message-ID: <20220705135959.GG23621@ziepe.ca> (raw)
In-Reply-To: <CAE_WKMzMi7A5qYp71ez=4E1BxcUNYCDeYq4DmFjxWMoHYRusAA@mail.gmail.com>
On Tue, Jul 05, 2022 at 11:28:59AM +0200, haris iqbal wrote:
> On Wed, Jun 29, 2022 at 8:48 PM Pearson, Robert B
> <robert.pearson2@hpe.com> wrote:
> >
> > > > > If the rkey's and lkeys are always the same why do we store them twice in the mr ?
> > > >
> > > > They are not always the same currently. If you request remote access they are the same if you don't rkey is set to zero.
> > > > You could, of course, check both the keys and the access bits but that is not the way it is written currently.
> >
> > > Storing the rkey instead of checking the flags seems like a weird obfuscation to me..
> >
> > > Jason
> >
> > One always has the choice to always just use the lkey and check the flags. But referring the rkey just uses one memory reference 😊
>
> Have we reached a consensus here as to how to solve this?
>
> This (and the issue created by dual map) has basically caused a
> regression in RTRS since the 5.15. And we would appreciate it a lot if
> the fix goes in and is backported.
I think your patch is close, it should just be tweaked a bit.
Jason
next prev parent reply other threads:[~2022-07-05 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 16:49 [PATCH] RDMA/rxe: For invalidate compare keys according to the MR access Md Haris Iqbal
2022-06-29 17:20 ` haris iqbal
2022-06-29 18:34 ` Jason Gunthorpe
2022-06-29 18:40 ` Pearson, Robert B
2022-06-29 18:44 ` Jason Gunthorpe
2022-06-29 18:47 ` Pearson, Robert B
2022-07-05 9:28 ` haris iqbal
2022-07-05 13:59 ` Jason Gunthorpe [this message]
2022-07-06 3:41 ` haris iqbal
2022-07-06 16:39 ` Jason Gunthorpe
2022-07-07 7:32 ` haris iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705135959.GG23621@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aleksei.marov@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=haris.phnx@gmail.com \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=robert.pearson2@hpe.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox