public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH for-next 2/6] RDMA/bnxt_re: Add disassociate ucontext support
Date: Mon, 10 Apr 2023 15:27:01 +0300	[thread overview]
Message-ID: <20230410122701.GQ182481@unreal> (raw)
In-Reply-To: <1681125115-7127-3-git-send-email-selvin.xavier@broadcom.com>

On Mon, Apr 10, 2023 at 04:11:51AM -0700, Selvin Xavier wrote:
> Add empty stub for disassociate ucontext as done in other vendor
> drivers.

It will be great to mention in commit message that the reason to this
stub is because you use rdma_user_mmap_io().

Thanks

> 
> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index 1d361eb..a866951 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -466,6 +466,10 @@ static int bnxt_re_net_stats_ctx_alloc(struct bnxt_re_dev *rdev,
>  	return rc;
>  }
>  
> +static void bnxt_re_disassociate_ucontext(struct ib_ucontext *ibcontext)
> +{
> +}
> +
>  /* Device */
>  
>  static struct bnxt_re_dev *bnxt_re_from_netdev(struct net_device *netdev)
> @@ -532,6 +536,7 @@ static const struct ib_device_ops bnxt_re_dev_ops = {
>  	.destroy_qp = bnxt_re_destroy_qp,
>  	.destroy_srq = bnxt_re_destroy_srq,
>  	.device_group = &bnxt_re_dev_attr_group,
> +	.disassociate_ucontext = bnxt_re_disassociate_ucontext,
>  	.get_dev_fw_str = bnxt_re_query_fw_str,
>  	.get_dma_mr = bnxt_re_get_dma_mr,
>  	.get_hw_stats = bnxt_re_ib_get_hw_stats,
> -- 
> 2.5.5
> 



  reply	other threads:[~2023-04-10 12:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 11:11 [PATCH for-next 0/6] RDMA/bnxt_re: driver update for supporting low latency push Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 1/6] RDMA/bnxt_re: Use the common mmap helper functions Selvin Xavier
2023-04-10 12:20   ` Leon Romanovsky
2023-04-11 16:53   ` Jason Gunthorpe
2023-04-12  6:49     ` Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 2/6] RDMA/bnxt_re: Add disassociate ucontext support Selvin Xavier
2023-04-10 12:27   ` Leon Romanovsky [this message]
2023-04-11 16:49     ` Jason Gunthorpe
2023-04-10 11:11 ` [PATCH for-next 3/6] RDMA/bnxt_re: Query function capabilities from firmware Selvin Xavier
2023-04-10 12:28   ` Leon Romanovsky
2023-04-10 11:11 ` [PATCH for-next 4/6] RDMA/bnxt_re: Move the interface version to chip context structure Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 5/6] RDMA/bnxt_re: Reorg the bar mapping Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 6/6] RDMA/bnxt_re: Enable low latency push Selvin Xavier
2023-04-11 16:56   ` Jason Gunthorpe
2023-04-12  5:58     ` Selvin Xavier
2023-04-10 12:32 ` [PATCH for-next 0/6] RDMA/bnxt_re: driver update for supporting " Leon Romanovsky
2023-04-11  2:29   ` Selvin Xavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230410122701.GQ182481@unreal \
    --to=leon@kernel.org \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox