From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Selvin Xavier <selvin.xavier@broadcom.com>,
linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH for-next 2/6] RDMA/bnxt_re: Add disassociate ucontext support
Date: Tue, 11 Apr 2023 13:49:45 -0300 [thread overview]
Message-ID: <ZDWPqXhlkhMKXv04@ziepe.ca> (raw)
In-Reply-To: <20230410122701.GQ182481@unreal>
On Mon, Apr 10, 2023 at 03:27:01PM +0300, Leon Romanovsky wrote:
> On Mon, Apr 10, 2023 at 04:11:51AM -0700, Selvin Xavier wrote:
> > Add empty stub for disassociate ucontext as done in other vendor
> > drivers.
>
> It will be great to mention in commit message that the reason to this
> stub is because you use rdma_user_mmap_io().
That isn't the reason to do this stub..
It is some yet-to-be-cleaned-up way for the driver to indicate it
*fully* supports driver disassociation.
rdma_user_mmap_io() is part of that support, but the whole
functionality should be tested before setting this.
Jason
next prev parent reply other threads:[~2023-04-11 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 11:11 [PATCH for-next 0/6] RDMA/bnxt_re: driver update for supporting low latency push Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 1/6] RDMA/bnxt_re: Use the common mmap helper functions Selvin Xavier
2023-04-10 12:20 ` Leon Romanovsky
2023-04-11 16:53 ` Jason Gunthorpe
2023-04-12 6:49 ` Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 2/6] RDMA/bnxt_re: Add disassociate ucontext support Selvin Xavier
2023-04-10 12:27 ` Leon Romanovsky
2023-04-11 16:49 ` Jason Gunthorpe [this message]
2023-04-10 11:11 ` [PATCH for-next 3/6] RDMA/bnxt_re: Query function capabilities from firmware Selvin Xavier
2023-04-10 12:28 ` Leon Romanovsky
2023-04-10 11:11 ` [PATCH for-next 4/6] RDMA/bnxt_re: Move the interface version to chip context structure Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 5/6] RDMA/bnxt_re: Reorg the bar mapping Selvin Xavier
2023-04-10 11:11 ` [PATCH for-next 6/6] RDMA/bnxt_re: Enable low latency push Selvin Xavier
2023-04-11 16:56 ` Jason Gunthorpe
2023-04-12 5:58 ` Selvin Xavier
2023-04-10 12:32 ` [PATCH for-next 0/6] RDMA/bnxt_re: driver update for supporting " Leon Romanovsky
2023-04-11 2:29 ` Selvin Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDWPqXhlkhMKXv04@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andrew.gospodarek@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox