Re: [PATCH] verbs: Add RDMA write RC pingpong test

[Leon Romanovsky <leon@kernel.org>]

On Wed, May 10, 2023 at 03:30:00PM +0530, Animesh Kishore wrote:
> On Tue, May 9, 2023 at 7:07 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Tue, May 09, 2023 at 12:50:16PM +0300, Animesh Kishore wrote:
> > > - The test pingpongs data between server and client
> > > instance using RC QPs with RDMA write BTH opcode.
> > > - For RDMA write, there's no completion at responder. Hence,
> > > we send a sideband ACK(using socket) from requester side
> > > on completion. This indicates to responder that it has
> > > received data.
> > >
> > > Check available test arguments and help:
> > > ./build/bin/ibv_rc_wr_pingpong -h
> > >
> > > e.g.
> > > Run server instance:
> > > ./build/bin/ibv_rc_wr_pingpong -g 0 -d <ib_dev> -c -s 8192
> > >
> > > Run client instance:
> > > ./build/bin/ibv_rc_wr_pingpong -g 0 -d <ib_dev> -c -s 8192 <server IP>
> > >
> > > Signed-off-by: Animesh Kishore <animesh.kishore@gmail.com>
> > > ---
> > >  debian/ibverbs-utils.install         |   2 +
> > >  libibverbs/examples/CMakeLists.txt   |   3 +
> > >  libibverbs/examples/rc_wr_pingpong.c | 782 +++++++++++++++++++++++++++
> > >  libibverbs/man/CMakeLists.txt        |   1 +
> > >  libibverbs/man/ibv_rc_wr_pingpong.1  |  63 +++
> > >  5 files changed, 851 insertions(+)
> > >  create mode 100644 libibverbs/examples/rc_wr_pingpong.c
> > >  create mode 100644 libibverbs/man/ibv_rc_wr_pingpong.1
> >
> > Like I said in relevant PR https://github.com/linux-rdma/rdma-core/pull/1325#issuecomment-1531194836
> > This new ibv_rc_wr_pingpong is unlikely to be merged.
> >
> > Thanks
> 
> Hi Leon,
> 
> Do you suggest to wait for more comments or close the PR at once ?

You need to find more people who think that such application must be
included in rdma-core.

> 
> I think it's helpful for new users for below reasons.
> Helps demonstrate complete flow and API usages. Works as a reference
> to build IBverbs production applications which are typically in C/C++.
> 
> Also note, it's an overkill to extend existing example/rc_pingpong.c
> (uses send/recv) to support RDMA write.

It is unlikely to be accepted either.

> 
> Thanks
> Animesh