From: kernel test robot <lkp@intel.com>
To: Selvin Xavier <selvin.xavier@broadcom.com>,
jgg@ziepe.ca, leon@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linux-rdma@vger.kernel.org,
andrew.gospodarek@broadcom.com,
Kashyap Desai <kashyap.desai@broadcom.com>,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: Re: [PATCH for-next 10/17] RDMA/bnxt_re: handle command completions after driver detect a timedout
Date: Thu, 8 Jun 2023 20:53:29 +0800 [thread overview]
Message-ID: <202306082023.3MJIBDhd-lkp@intel.com> (raw)
In-Reply-To: <1686219908-11181-11-git-send-email-selvin.xavier@broadcom.com>
Hi Selvin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rdma/for-next]
[also build test WARNING on next-20230608]
[cannot apply to linus/master v6.4-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Selvin-Xavier/RDMA-bnxt_re-wraparound-mbox-producer-index/20230608-184033
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
patch link: https://lore.kernel.org/r/1686219908-11181-11-git-send-email-selvin.xavier%40broadcom.com
patch subject: [PATCH for-next 10/17] RDMA/bnxt_re: handle command completions after driver detect a timedout
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20230608/202306082023.3MJIBDhd-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add rdma https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
git fetch rdma for-next
git checkout rdma/for-next
b4 shazam https://lore.kernel.org/r/1686219908-11181-11-git-send-email-selvin.xavier@broadcom.com
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/infiniband/hw/bnxt_re/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306082023.3MJIBDhd-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c: In function '__wait_for_resp':
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:108:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
108 | int ret;
| ^~~
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c: In function '__send_message':
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:173:20: warning: variable 'opcode' set but not used [-Wunused-but-set-variable]
173 | u32 bsize, opcode, free_slots, required_slots;
| ^~~~~~
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c: In function 'bnxt_qplib_process_qp_event':
>> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:502:17: warning: variable 'mcookie' set but not used [-Wunused-but-set-variable]
502 | __le16 mcookie;
| ^~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE
Depends on [n]: IOMMU_SUPPORT [=y] && (ARM || ARM64 || COMPILE_TEST [=n]) && !GENERIC_ATOMIC64 [=n]
Selected by [y]:
- IPMMU_VMSA [=y] && IOMMU_SUPPORT [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) && !GENERIC_ATOMIC64 [=n]
vim +/mcookie +502 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
1ac5a404797523 Selvin Xavier 2017-02-10 487
1ac5a404797523 Selvin Xavier 2017-02-10 488 static int bnxt_qplib_process_qp_event(struct bnxt_qplib_rcfw *rcfw,
1020ce59adaac6 Kashyap Desai 2023-06-08 489 struct creq_qp_event *qp_event,
1020ce59adaac6 Kashyap Desai 2023-06-08 490 u32 *num_wait)
1ac5a404797523 Selvin Xavier 2017-02-10 491 {
f218d67ef00431 Selvin Xavier 2017-06-29 492 struct creq_qp_error_notification *err_event;
cee0c7bba48691 Devesh Sharma 2020-02-15 493 struct bnxt_qplib_hwq *hwq = &rcfw->cmdq.hwq;
cee0c7bba48691 Devesh Sharma 2020-02-15 494 struct bnxt_qplib_crsqe *crsqe;
9a38dbbd424de0 Kashyap Desai 2023-06-08 495 u32 qp_id, tbl_indx, req_size;
f218d67ef00431 Selvin Xavier 2017-06-29 496 struct bnxt_qplib_qp *qp;
cc1ec769b87c7d Devesh Sharma 2017-05-22 497 u16 cbit, blocked = 0;
9a38dbbd424de0 Kashyap Desai 2023-06-08 498 bool is_waiter_alive;
cee0c7bba48691 Devesh Sharma 2020-02-15 499 struct pci_dev *pdev;
cee0c7bba48691 Devesh Sharma 2020-02-15 500 unsigned long flags;
1020ce59adaac6 Kashyap Desai 2023-06-08 501 u32 wait_cmds = 0;
cc1ec769b87c7d Devesh Sharma 2017-05-22 @502 __le16 mcookie;
cee0c7bba48691 Devesh Sharma 2020-02-15 503 u16 cookie;
cee0c7bba48691 Devesh Sharma 2020-02-15 504 int rc = 0;
1ac5a404797523 Selvin Xavier 2017-02-10 505
cee0c7bba48691 Devesh Sharma 2020-02-15 506 pdev = rcfw->pdev;
1ac5a404797523 Selvin Xavier 2017-02-10 507 switch (qp_event->event) {
1ac5a404797523 Selvin Xavier 2017-02-10 508 case CREQ_QP_EVENT_EVENT_QP_ERROR_NOTIFICATION:
f218d67ef00431 Selvin Xavier 2017-06-29 509 err_event = (struct creq_qp_error_notification *)qp_event;
f218d67ef00431 Selvin Xavier 2017-06-29 510 qp_id = le32_to_cpu(err_event->xid);
84cf229f4001c1 Selvin Xavier 2020-08-24 511 tbl_indx = map_qp_id_to_tbl_indx(qp_id, rcfw);
84cf229f4001c1 Selvin Xavier 2020-08-24 512 qp = rcfw->qp_tbl[tbl_indx].qp_handle;
cee0c7bba48691 Devesh Sharma 2020-02-15 513 dev_dbg(&pdev->dev, "Received QP error notification\n");
cee0c7bba48691 Devesh Sharma 2020-02-15 514 dev_dbg(&pdev->dev,
08920b8f5d2d3b Joe Perches 2018-08-10 515 "qpid 0x%x, req_err=0x%x, resp_err=0x%x\n",
f218d67ef00431 Selvin Xavier 2017-06-29 516 qp_id, err_event->req_err_state_reason,
f218d67ef00431 Selvin Xavier 2017-06-29 517 err_event->res_err_state_reason);
d6d5c59905c8af Sriharsha Basavapatna 2017-10-31 518 if (!qp)
d6d5c59905c8af Sriharsha Basavapatna 2017-10-31 519 break;
f218d67ef00431 Selvin Xavier 2017-06-29 520 bnxt_qplib_mark_qp_error(qp);
cee0c7bba48691 Devesh Sharma 2020-02-15 521 rc = rcfw->creq.aeq_handler(rcfw, qp_event, qp);
1ac5a404797523 Selvin Xavier 2017-02-10 522 break;
1ac5a404797523 Selvin Xavier 2017-02-10 523 default:
d455f29f6d76a5 Selvin Xavier 2018-10-08 524 /*
d455f29f6d76a5 Selvin Xavier 2018-10-08 525 * Command Response
d455f29f6d76a5 Selvin Xavier 2018-10-08 526 * cmdq->lock needs to be acquired to synchronie
d455f29f6d76a5 Selvin Xavier 2018-10-08 527 * the command send and completion reaping. This function
d455f29f6d76a5 Selvin Xavier 2018-10-08 528 * is always called with creq->lock held. Using
d455f29f6d76a5 Selvin Xavier 2018-10-08 529 * the nested variant of spin_lock.
d455f29f6d76a5 Selvin Xavier 2018-10-08 530 *
d455f29f6d76a5 Selvin Xavier 2018-10-08 531 */
d455f29f6d76a5 Selvin Xavier 2018-10-08 532
cee0c7bba48691 Devesh Sharma 2020-02-15 533 spin_lock_irqsave_nested(&hwq->lock, flags,
d455f29f6d76a5 Selvin Xavier 2018-10-08 534 SINGLE_DEPTH_NESTING);
cc1ec769b87c7d Devesh Sharma 2017-05-22 535 cookie = le16_to_cpu(qp_event->cookie);
cc1ec769b87c7d Devesh Sharma 2017-05-22 536 mcookie = qp_event->cookie;
1ac5a404797523 Selvin Xavier 2017-02-10 537 blocked = cookie & RCFW_CMD_IS_BLOCKING;
1ac5a404797523 Selvin Xavier 2017-02-10 538 cookie &= RCFW_MAX_COOKIE_VALUE;
bd1c24ccf9eb07 Devesh Sharma 2018-12-12 539 cbit = cookie % rcfw->cmdq_depth;
cc1ec769b87c7d Devesh Sharma 2017-05-22 540 crsqe = &rcfw->crsqe_tbl[cbit];
cee0c7bba48691 Devesh Sharma 2020-02-15 541 if (!test_and_clear_bit(cbit, rcfw->cmdq.cmdq_bitmap))
cee0c7bba48691 Devesh Sharma 2020-02-15 542 dev_warn(&pdev->dev,
08920b8f5d2d3b Joe Perches 2018-08-10 543 "CMD bit %d was not requested\n", cbit);
cc1ec769b87c7d Devesh Sharma 2017-05-22 544
9a38dbbd424de0 Kashyap Desai 2023-06-08 545 if (crsqe->is_waiter_alive) {
9a38dbbd424de0 Kashyap Desai 2023-06-08 546 if (crsqe->resp)
9a38dbbd424de0 Kashyap Desai 2023-06-08 547 memcpy(crsqe->resp, qp_event, sizeof(*qp_event));
1ac5a404797523 Selvin Xavier 2017-02-10 548 if (!blocked)
1020ce59adaac6 Kashyap Desai 2023-06-08 549 wait_cmds++;
9a38dbbd424de0 Kashyap Desai 2023-06-08 550 }
9a38dbbd424de0 Kashyap Desai 2023-06-08 551
9a38dbbd424de0 Kashyap Desai 2023-06-08 552 req_size = crsqe->req_size;
9a38dbbd424de0 Kashyap Desai 2023-06-08 553 is_waiter_alive = crsqe->is_waiter_alive;
9a38dbbd424de0 Kashyap Desai 2023-06-08 554
9a38dbbd424de0 Kashyap Desai 2023-06-08 555 crsqe->req_size = 0;
9a38dbbd424de0 Kashyap Desai 2023-06-08 556 if (!is_waiter_alive)
9a38dbbd424de0 Kashyap Desai 2023-06-08 557 crsqe->resp = NULL;
9a38dbbd424de0 Kashyap Desai 2023-06-08 558
9a38dbbd424de0 Kashyap Desai 2023-06-08 559 hwq->cons += req_size;
cee0c7bba48691 Devesh Sharma 2020-02-15 560 spin_unlock_irqrestore(&hwq->lock, flags);
1ac5a404797523 Selvin Xavier 2017-02-10 561 }
1020ce59adaac6 Kashyap Desai 2023-06-08 562 *num_wait += wait_cmds;
cee0c7bba48691 Devesh Sharma 2020-02-15 563 return rc;
1ac5a404797523 Selvin Xavier 2017-02-10 564 }
1ac5a404797523 Selvin Xavier 2017-02-10 565
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-06-08 12:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 10:24 [PATCH for-next 00/17] RDMA/bnxt_re: Control path updates Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 01/17] RDMA/bnxt_re: wraparound mbox producer index Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 02/17] RDMA/bnxt_re: Avoid calling wake_up threads from spin_lock context Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 03/17] RDMA/bnxt_re: remove virt_func check while creating RoCE FW channel Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 04/17] RDMA/bnxt_re: set fixed command queue depth Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 05/17] RDMA/bnxt_re: Enhance the existing functions that wait for FW responses Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 06/17] RDMA/bnxt_re: Avoid the command wait if firmware is inactive Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 07/17] RDMA/bnxt_re: use shadow qd while posting non blocking rcfw command Selvin Xavier
2023-06-08 10:24 ` [PATCH for-next 08/17] RDMA/bnxt_re: Simplify the function that sends the FW commands Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 09/17] RDMA/bnxt_re: add helper function __poll_for_resp Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 10/17] RDMA/bnxt_re: handle command completions after driver detect a timedout Selvin Xavier
2023-06-08 12:53 ` kernel test robot [this message]
2023-06-08 10:25 ` [PATCH for-next 11/17] RDMA/bnxt_re: Add firmware stall check detection Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 12/17] RDMA/bnxt_re: post destroy_ah for delayed completion of AH creation Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 13/17] RDMA/bnxt_re: consider timeout of destroy ah as success Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 14/17] RDMA/bnxt_re: cancel all control path command waiters upon error Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 15/17] RDMA/bnxt_re: use firmware provided max request timeout Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 16/17] RDMA/bnxt_re: remove redundant cmdq_bitmap Selvin Xavier
2023-06-08 10:25 ` [PATCH for-next 17/17] RDMA/bnxt_re: optimize the parameters passed to helper functions Selvin Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306082023.3MJIBDhd-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=kashyap.desai@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox