From: Md Haris Iqbal <haris.iqbal@ionos.com>
To: linux-rdma@vger.kernel.org
Cc: bvanassche@acm.org, leon@kernel.org, jgg@ziepe.ca,
haris.iqbal@ionos.com, jinpu.wang@ionos.com,
Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
Subject: [PATCH v2 for-next 4/9] RDMA/rtrs-srv: Free srv_mr iu only when always_invalidate is true
Date: Mon, 20 Nov 2023 16:41:41 +0100 [thread overview]
Message-ID: <20231120154146.920486-5-haris.iqbal@ionos.com> (raw)
In-Reply-To: <20231120154146.920486-1-haris.iqbal@ionos.com>
Since srv_mr->iu is allocated and used only when always_invalidate is
true, free it only when always_invalidate is true.
Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality")
Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
---
drivers/infiniband/ulp/rtrs/rtrs-srv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
index 4be0e5b132d4..925b71481c62 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
@@ -551,7 +551,10 @@ static void unmap_cont_bufs(struct rtrs_srv_path *srv_path)
struct rtrs_srv_mr *srv_mr;
srv_mr = &srv_path->mrs[i];
- rtrs_iu_free(srv_mr->iu, srv_path->s.dev->ib_dev, 1);
+
+ if (always_invalidate)
+ rtrs_iu_free(srv_mr->iu, srv_path->s.dev->ib_dev, 1);
+
ib_dereg_mr(srv_mr->mr);
ib_dma_unmap_sg(srv_path->s.dev->ib_dev, srv_mr->sgt.sgl,
srv_mr->sgt.nents, DMA_BIDIRECTIONAL);
--
2.25.1
next prev parent reply other threads:[~2023-11-20 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 15:41 [PATCH v2 for-next 0/9] Misc patches for RTRS Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 1/9] RDMA/rtrs-srv: Do not unconditionally enable irq Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 2/9] RDMA/rtrs-clt: Start hb after path_up Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 3/9] RDMA/rtrs-srv: Check return values while processing info request Md Haris Iqbal
2023-11-20 15:41 ` Md Haris Iqbal [this message]
2023-11-20 15:41 ` [PATCH v2 for-next 5/9] RDMA/rtrs-srv: Destroy path files after making sure no IOs in-flight Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 6/9] RDMA/rtrs-clt: Fix the max_send_wr setting Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 7/9] RDMA/rtrs-clt: Remove the warnings for req in_use check Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 8/9] RDMA/rtrs-clt: use %pe to print errors Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 9/9] RDMA/rtrs: " Md Haris Iqbal
2023-11-22 11:44 ` [PATCH v2 for-next 0/9] Misc patches for RTRS Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120154146.920486-5-haris.iqbal@ionos.com \
--to=haris.iqbal@ionos.com \
--cc=bvanassche@acm.org \
--cc=grzegorz.prajsner@ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox