Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Md Haris Iqbal <haris.iqbal@ionos.com>
To: linux-rdma@vger.kernel.org
Cc: bvanassche@acm.org, leon@kernel.org, jgg@ziepe.ca,
	haris.iqbal@ionos.com, jinpu.wang@ionos.com,
	Supriti Singh <supriti.singh@ionos.com>,
	Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
Subject: [PATCH v2 for-next 8/9] RDMA/rtrs-clt: use %pe to print errors
Date: Mon, 20 Nov 2023 16:41:45 +0100	[thread overview]
Message-ID: <20231120154146.920486-9-haris.iqbal@ionos.com> (raw)
In-Reply-To: <20231120154146.920486-1-haris.iqbal@ionos.com>

From: Supriti Singh <supriti.singh@ionos.com>

While printing error, replace %ld by %pe. %pe prints a string
whereas %ld would print an error code.

Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
Signed-off-by: Supriti Singh <supriti.singh@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
---
 drivers/infiniband/ulp/rtrs/rtrs-clt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index 8c5054d18402..493efbba2fe3 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -1391,9 +1391,9 @@ static int alloc_path_reqs(struct rtrs_clt_path *clt_path)
 				      clt_path->max_pages_per_mr);
 		if (IS_ERR(req->mr)) {
 			err = PTR_ERR(req->mr);
+			pr_err("Failed to alloc clt_path->max_pages_per_mr %d: %pe\n",
+			       clt_path->max_pages_per_mr, req->mr);
 			req->mr = NULL;
-			pr_err("Failed to alloc clt_path->max_pages_per_mr %d\n",
-			       clt_path->max_pages_per_mr);
 			goto out;
 		}
 
@@ -2061,7 +2061,7 @@ static int create_cm(struct rtrs_clt_con *con)
 			       RDMA_PS_IB : RDMA_PS_TCP, IB_QPT_RC);
 	if (IS_ERR(cm_id)) {
 		err = PTR_ERR(cm_id);
-		rtrs_err(s, "Failed to create CM ID, err: %d\n", err);
+		rtrs_err(s, "Failed to create CM ID, err: %pe\n", cm_id);
 
 		return err;
 	}
-- 
2.25.1


  parent reply	other threads:[~2023-11-20 15:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 15:41 [PATCH v2 for-next 0/9] Misc patches for RTRS Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 1/9] RDMA/rtrs-srv: Do not unconditionally enable irq Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 2/9] RDMA/rtrs-clt: Start hb after path_up Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 3/9] RDMA/rtrs-srv: Check return values while processing info request Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 4/9] RDMA/rtrs-srv: Free srv_mr iu only when always_invalidate is true Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 5/9] RDMA/rtrs-srv: Destroy path files after making sure no IOs in-flight Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 6/9] RDMA/rtrs-clt: Fix the max_send_wr setting Md Haris Iqbal
2023-11-20 15:41 ` [PATCH v2 for-next 7/9] RDMA/rtrs-clt: Remove the warnings for req in_use check Md Haris Iqbal
2023-11-20 15:41 ` Md Haris Iqbal [this message]
2023-11-20 15:41 ` [PATCH v2 for-next 9/9] RDMA/rtrs: use %pe to print errors Md Haris Iqbal
2023-11-22 11:44 ` [PATCH v2 for-next 0/9] Misc patches for RTRS Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231120154146.920486-9-haris.iqbal@ionos.com \
    --to=haris.iqbal@ionos.com \
    --cc=bvanassche@acm.org \
    --cc=grzegorz.prajsner@ionos.com \
    --cc=jgg@ziepe.ca \
    --cc=jinpu.wang@ionos.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=supriti.singh@ionos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox