From: Matthew W Carlis <mattc@purestorage.com>
To: macro@orcam.me.uk
Cc: alex.williamson@redhat.com, bhelgaas@google.com,
davem@davemloft.net, david.abdurachmanov@gmail.com,
edumazet@google.com, helgaas@kernel.org, kuba@kernel.org,
leon@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, lukas@wunner.de,
mahesh@linux.ibm.com, mika.westerberg@linux.intel.com,
netdev@vger.kernel.org, npiggin@gmail.com, oohall@gmail.com,
pabeni@redhat.com, pali@kernel.org, saeedm@nvidia.com,
sr@denx.de, wilson@tuliptree.org
Subject: PCI: Work around PCIe link training failures
Date: Mon, 5 Aug 2024 18:06:59 -0600 [thread overview]
Message-ID: <20240806000659.30859-1-mattc@purestorage.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2306201040200.14084@angie.orcam.me.uk>
Hello again. I just realized that my first response to this thread two weeks
ago was not actually starting from the end of the discussion. I hope I found
it now... Must say sorry for this I am still figuring out how to follow these
threads.
I need to ask if we can either revert this patch or only modify the quirk to
only run on the device in mention (ASMedia ASM2824). We have now identified
it as causing devices to get stuck at Gen1 in multiple generations of our
hardware & across product lines on ports were hot-plug is common. To be a
little more specific it includes Intel root ports and Broadcomm PCIe switch
ports and also Microchip PCIe switch ports.
The most common place where we see our systems getting stuck at Gen1 is with
device power cycling. If a device is powered on and then off quickly then the
link will of course fail to train & the consequence here is that the port is
forced to Gen1 forever. Does anybody know why the patch will only remove the
forced Gen1 speed from the ASMedia device?
- Matt
next prev parent reply other threads:[~2024-08-06 0:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 17:19 [PATCH v9 00/14] pci: Work around ASMedia ASM2824 PCIe link training failures Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 01/14] PCI: pciehp: Rely on `link_active_reporting' Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 02/14] PCI: Export PCIe link retrain timeout Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 03/14] PCI: Execute `quirk_enable_clear_retrain_link' earlier Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 04/14] PCI: Initialize `link_active_reporting' earlier Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 05/14] powerpc/eeh: Rely on `link_active_reporting' Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 06/14] net/mlx5: " Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 07/14] PCI: Export `pcie_retrain_link' for use outside ASPM Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 08/14] PCI: Use distinct local vars in `pcie_retrain_link' Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 09/14] PCI: Factor our waiting for link training end Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 10/14] PCI: Add support for polling DLLLA to `pcie_retrain_link' Maciej W. Rozycki
2023-06-11 17:19 ` [PATCH v9 11/14] PCI: Use `pcie_wait_for_link_status' in `pcie_wait_for_link_delay' Maciej W. Rozycki
2023-06-11 17:20 ` [PATCH v9 12/14] PCI: Provide stub failed link recovery for device probing and hot plug Maciej W. Rozycki
2024-07-22 19:34 ` PCI: Work around PCIe link training failures Matthew W Carlis
2024-07-22 20:40 ` Maciej W. Rozycki
2024-07-24 19:18 ` Matthew W Carlis
2024-07-26 8:04 ` Matthew W Carlis
2024-07-29 10:27 ` Ilpo Järvinen
2024-07-29 14:51 ` Maciej W. Rozycki
2024-07-29 18:56 ` Matthew W Carlis
2023-06-11 17:20 ` [PATCH v9 13/14] PCI: Add failed link recovery for device reset events Maciej W. Rozycki
2023-06-11 17:20 ` [PATCH v9 14/14] PCI: Work around PCIe link training failures Maciej W. Rozycki
2023-06-14 23:12 ` [PATCH v9 00/14] pci: Work around ASMedia ASM2824 " Bjorn Helgaas
2023-06-15 0:41 ` Maciej W. Rozycki
2023-06-15 18:37 ` Bjorn Helgaas
2023-06-16 12:27 ` Maciej W. Rozycki
2023-06-16 20:29 ` Bjorn Helgaas
2023-06-20 9:54 ` Maciej W. Rozycki
2024-08-06 0:06 ` Matthew W Carlis [this message]
2024-08-06 19:36 ` PCI: Work around " Bjorn Helgaas
2024-08-07 8:43 ` Matthew W Carlis
2024-08-07 11:14 ` Maciej W. Rozycki
2024-08-07 12:29 ` Oliver O'Halloran
2024-08-07 11:49 ` Maciej W. Rozycki
2024-08-08 2:07 ` Matthew W Carlis
2024-08-08 23:13 ` Oliver O'Halloran
2024-08-09 13:34 ` Maciej W. Rozycki
2024-08-15 19:40 ` Matthew W Carlis
2024-08-16 13:57 ` Maciej W. Rozycki
2024-10-01 21:04 ` Matthew W Carlis
2024-10-02 12:58 ` Maciej W. Rozycki
2024-10-02 20:55 ` Bjorn Helgaas
2024-10-03 10:39 ` Maciej W. Rozycki
2025-06-10 7:00 ` Matthew W Carlis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806000659.30859-1-mattc@purestorage.com \
--to=mattc@purestorage.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=david.abdurachmanov@gmail.com \
--cc=edumazet@google.com \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=mahesh@linux.ibm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=pabeni@redhat.com \
--cc=pali@kernel.org \
--cc=saeedm@nvidia.com \
--cc=sr@denx.de \
--cc=wilson@tuliptree.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox