Re: [PATCH for-next 1/4] RDMA/bnxt_re: Change aux driver data to en_info to hold more information

[kernel test robot <lkp@intel.com>]

Hi Selvin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on next-20240910]
[cannot apply to linus/master v6.11-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Selvin-Xavier/RDMA-bnxt_re-Change-aux-driver-data-to-en_info-to-hold-more-information/20240910-122414
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
patch link:    https://lore.kernel.org/r/1725940862-4821-2-git-send-email-selvin.xavier%40broadcom.com
patch subject: [PATCH for-next 1/4] RDMA/bnxt_re: Change aux driver data to en_info to hold more information
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240911/202409110129.V1tgNuph-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409110129.V1tgNuph-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409110129.V1tgNuph-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/bnxt_re/main.c: In function 'bnxt_re_remove':
>> drivers/infiniband/hw/bnxt_re/main.c:1939:29: warning: variable 'en_dev' set but not used [-Wunused-but-set-variable]
    1939 |         struct bnxt_en_dev *en_dev;
         |                             ^~~~~~


vim +/en_dev +1939 drivers/infiniband/hw/bnxt_re/main.c

  1935	
  1936	static void bnxt_re_remove(struct auxiliary_device *adev)
  1937	{
  1938		struct bnxt_re_en_dev_info *en_info = auxiliary_get_drvdata(adev);
> 1939		struct bnxt_en_dev *en_dev;
  1940		struct bnxt_re_dev *rdev;
  1941	
  1942		mutex_lock(&bnxt_re_mutex);
  1943		if (!en_info) {
  1944			mutex_unlock(&bnxt_re_mutex);
  1945			return;
  1946		}
  1947		en_dev = en_info->en_dev;
  1948		rdev = en_info->rdev;
  1949		if (!rdev)
  1950			goto skip_remove;
  1951	
  1952		if (rdev->nb.notifier_call) {
  1953			unregister_netdevice_notifier(&rdev->nb);
  1954			rdev->nb.notifier_call = NULL;
  1955		} else {
  1956			/* If notifier is null, we should have already done a
  1957			 * clean up before coming here.
  1958			 */
  1959			goto skip_remove;
  1960		}
  1961		bnxt_re_setup_cc(rdev, false);
  1962		ib_unregister_device(&rdev->ibdev);
  1963		bnxt_re_dev_uninit(rdev);
  1964		ib_dealloc_device(&rdev->ibdev);
  1965	skip_remove:
  1966		kfree(en_info);
  1967		mutex_unlock(&bnxt_re_mutex);
  1968	}
  1969	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki