public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Selvin Xavier <selvin.xavier@broadcom.com>,
	leon@kernel.org, jgg@ziepe.ca
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com,
	kalesh-anakkur.purayil@broadcom.com,
	Preethi G <preethi.gurusiddalingeswaraswamy@broadcom.com>,
	Selvin Xavier <selvin.xavier@broadcom.com>
Subject: Re: [PATCH rdma-next] RDMA/bnxt_re: Support Perf management counters
Date: Wed, 12 Mar 2025 15:55:51 +0800	[thread overview]
Message-ID: <202503121530.oThTZxSC-lkp@intel.com> (raw)
In-Reply-To: <1741674104-5477-1-git-send-email-selvin.xavier@broadcom.com>

Hi Selvin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on linus/master v6.14-rc6 next-20250311]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Selvin-Xavier/RDMA-bnxt_re-Support-Perf-management-counters/20250311-144413
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
patch link:    https://lore.kernel.org/r/1741674104-5477-1-git-send-email-selvin.xavier%40broadcom.com
patch subject: [PATCH rdma-next] RDMA/bnxt_re: Support Perf management counters
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20250312/202503121530.oThTZxSC-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503121530.oThTZxSC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503121530.oThTZxSC-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/bnxt_re/hw_counters.c: In function 'bnxt_re_assign_pma_port_ext_counters':
>> drivers/infiniband/hw/bnxt_re/hw_counters.c:295:13: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
     295 |         int rc;
         |             ^~
   drivers/infiniband/hw/bnxt_re/hw_counters.c: In function 'bnxt_re_assign_pma_port_counters':
   drivers/infiniband/hw/bnxt_re/hw_counters.c:338:13: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
     338 |         int rc;
         |             ^~


vim +/rc +295 drivers/infiniband/hw/bnxt_re/hw_counters.c

   289	
   290	int bnxt_re_assign_pma_port_ext_counters(struct bnxt_re_dev *rdev, struct ib_mad *out_mad)
   291	{
   292		struct ib_pma_portcounters_ext *pma_cnt_ext;
   293		struct bnxt_qplib_ext_stat *estat = &rdev->stats.rstat.ext_stat;
   294		struct ctx_hw_stats *hw_stats = NULL;
 > 295		int rc;
   296	
   297		hw_stats = rdev->qplib_ctx.stats.dma;
   298	
   299		pma_cnt_ext = (void *)(out_mad->data + 40);
   300		if (_is_ext_stats_supported(rdev->dev_attr->dev_cap_flags)) {
   301			u32 fid = PCI_FUNC(rdev->en_dev->pdev->devfn);
   302	
   303			rc = bnxt_qplib_qext_stat(&rdev->rcfw, fid, estat);
   304		}
   305	
   306		pma_cnt_ext = (void *)(out_mad->data + 40);
   307		if ((bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx) && rdev->is_virtfn) ||
   308		    !bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx)) {
   309			pma_cnt_ext->port_xmit_data =
   310				cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_bytes) / 4);
   311			pma_cnt_ext->port_rcv_data =
   312				cpu_to_be64(le64_to_cpu(hw_stats->rx_ucast_bytes) / 4);
   313			pma_cnt_ext->port_xmit_packets =
   314				cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_pkts));
   315			pma_cnt_ext->port_rcv_packets =
   316				cpu_to_be64(le64_to_cpu(hw_stats->rx_ucast_pkts));
   317			pma_cnt_ext->port_unicast_rcv_packets =
   318				cpu_to_be64(le64_to_cpu(hw_stats->rx_ucast_pkts));
   319			pma_cnt_ext->port_unicast_xmit_packets =
   320				cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_pkts));
   321	
   322		} else {
   323			pma_cnt_ext->port_rcv_packets = cpu_to_be64(estat->rx_roce_good_pkts);
   324			pma_cnt_ext->port_rcv_data = cpu_to_be64(estat->rx_roce_good_bytes / 4);
   325			pma_cnt_ext->port_xmit_packets = cpu_to_be64(estat->tx_roce_pkts);
   326			pma_cnt_ext->port_xmit_data = cpu_to_be64(estat->tx_roce_bytes / 4);
   327			pma_cnt_ext->port_unicast_rcv_packets = cpu_to_be64(estat->rx_roce_good_pkts);
   328			pma_cnt_ext->port_unicast_xmit_packets = cpu_to_be64(estat->tx_roce_pkts);
   329		}
   330		return 0;
   331	}
   332	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      reply	other threads:[~2025-03-12  7:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11  6:21 [PATCH rdma-next] RDMA/bnxt_re: Support Perf management counters Selvin Xavier
2025-03-12  7:55 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202503121530.oThTZxSC-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=jgg@ziepe.ca \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=preethi.gurusiddalingeswaraswamy@broadcom.com \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox