* [PATCHES] several fixes from tree-in-dcache stuff @ 2025-03-13 4:27 Al Viro 2025-03-13 4:30 ` [PATCH 4/4] qibfs: fix _another_ leak Al Viro 0 siblings, 1 reply; 3+ messages in thread From: Al Viro @ 2025-03-13 4:27 UTC (permalink / raw) To: linux-fsdevel; +Cc: linuxppc-dev, linux-rdma Several fixes for fairly old crap - qibfs leak, a couple of spufs ones and a spufs double-dput() memory corruptor. This stuff sits in viro/vfs.git#fixes; individual patches in followups. Review would be very welcome. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 4/4] qibfs: fix _another_ leak 2025-03-13 4:27 [PATCHES] several fixes from tree-in-dcache stuff Al Viro @ 2025-03-13 4:30 ` Al Viro 2025-03-13 8:29 ` Christian Brauner 0 siblings, 1 reply; 3+ messages in thread From: Al Viro @ 2025-03-13 4:30 UTC (permalink / raw) To: linux-fsdevel; +Cc: linux-rdma failure to allocate inode => leaked dentry... this one had been there since the initial merge; to be fair, if we are that far OOM, the odds of failing at that particular allocation are low... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- drivers/infiniband/hw/qib/qib_fs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/qib/qib_fs.c b/drivers/infiniband/hw/qib/qib_fs.c index b27791029fa9..b9f4a2937c3a 100644 --- a/drivers/infiniband/hw/qib/qib_fs.c +++ b/drivers/infiniband/hw/qib/qib_fs.c @@ -55,6 +55,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry, struct inode *inode = new_inode(dir->i_sb); if (!inode) { + dput(dentry); error = -EPERM; goto bail; } -- 2.39.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 4/4] qibfs: fix _another_ leak 2025-03-13 4:30 ` [PATCH 4/4] qibfs: fix _another_ leak Al Viro @ 2025-03-13 8:29 ` Christian Brauner 0 siblings, 0 replies; 3+ messages in thread From: Christian Brauner @ 2025-03-13 8:29 UTC (permalink / raw) To: Al Viro; +Cc: linux-fsdevel, linux-rdma On Thu, Mar 13, 2025 at 04:30:20AM +0000, Al Viro wrote: > failure to allocate inode => leaked dentry... > > this one had been there since the initial merge; to be fair, > if we are that far OOM, the odds of failing at that particular > allocation are low... > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > --- Reviewed-by: Christian Brauner <brauner@kernel.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-13 8:29 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-03-13 4:27 [PATCHES] several fixes from tree-in-dcache stuff Al Viro 2025-03-13 4:30 ` [PATCH 4/4] qibfs: fix _another_ leak Al Viro 2025-03-13 8:29 ` Christian Brauner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox