From: Jason Gunthorpe <jgg@ziepe.ca>
To: Patrisious Haddad <phaddad@nvidia.com>
Cc: Mark Bloch <mbloch@nvidia.com>, Arnd Bergmann <arnd@kernel.org>,
Leon Romanovsky <leon@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Tariq Toukan <tariqt@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Moshe Shemesh <moshe@nvidia.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: hide unused code
Date: Tue, 1 Apr 2025 12:36:13 -0300 [thread overview]
Message-ID: <20250401153613.GH186258@ziepe.ca> (raw)
In-Reply-To: <84bf60b7-2d7e-4549-8e81-bc35efeef069@nvidia.com>
On Tue, Apr 01, 2025 at 06:20:09PM +0300, Patrisious Haddad wrote:
> > > #ifdefing away half the file seems ugly.
> agreed, which is why I think mark bloch suggestion makes more sense, do you
> think it is okay ? or you think there is issues with it ?
I think you should split the file so we get the proper level of code
elimination.
But Mark's is small and sane enough to fix the build problems.
Jason
prev parent reply other threads:[~2025-04-01 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 13:10 [PATCH] RDMA/mlx5: hide unused code Arnd Bergmann
2025-03-28 13:15 ` Jason Gunthorpe
2025-03-28 13:20 ` Arnd Bergmann
2025-03-31 9:30 ` Mark Bloch
2025-04-01 15:20 ` Patrisious Haddad
2025-04-01 15:36 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401153613.GH186258@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox