From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jason Gunthorpe" <jgg@ziepe.ca>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Leon Romanovsky" <leon@kernel.org>,
"Patrisious Haddad" <phaddad@nvidia.com>,
"Mark Bloch" <mbloch@nvidia.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Moshe Shemesh" <moshe@nvidia.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: hide unused code
Date: Fri, 28 Mar 2025 14:20:30 +0100 [thread overview]
Message-ID: <cdaf0e11-3de2-4979-8112-7865c63c0ffd@app.fastmail.com> (raw)
In-Reply-To: <20250328131513.GB20836@ziepe.ca>
On Fri, Mar 28, 2025, at 14:15, Jason Gunthorpe wrote:
> On Fri, Mar 28, 2025 at 02:10:17PM +0100, Arnd Bergmann wrote:
>
> IDK, I'm tempted to revert 36e0d433672f ("RDMA/mlx5: Compile fs.c
> regardless of INFINIBAND_USER_ACCESS config")
>
> I don't think that was so well thought out. The entire file was
> designed to be USER_ACCESS only because it uses all this mechanism.
>
> #ifdefing away half the file seems ugly.
That sounds better to me, yes. I assumed that a later patch
required that one, but I don't see such a dependency.
Arnd
next prev parent reply other threads:[~2025-03-28 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 13:10 [PATCH] RDMA/mlx5: hide unused code Arnd Bergmann
2025-03-28 13:15 ` Jason Gunthorpe
2025-03-28 13:20 ` Arnd Bergmann [this message]
2025-03-31 9:30 ` Mark Bloch
2025-04-01 15:20 ` Patrisious Haddad
2025-04-01 15:36 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdaf0e11-3de2-4979-8112-7865c63c0ffd@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox