* [PATCH rdma-rc] RDMA/bnxt_re: Remove unusable nq variable
@ 2025-04-10 12:32 Leon Romanovsky
2025-04-10 23:30 ` Jason Gunthorpe
2025-04-11 2:56 ` Kalesh Anakkur Purayil
0 siblings, 2 replies; 3+ messages in thread
From: Leon Romanovsky @ 2025-04-10 12:32 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Leon Romanovsky, Kalesh AP, Kashyap Desai, kernel test robot,
linux-rdma, Selvin Xavier
From: Leon Romanovsky <leonro@nvidia.com>
Remove nq variable from bnxt_re_create_srq() and bnxt_re_destroy_srq()
as it generates the following compilation warnings:
>> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1777:24: warning: variable
'nq' set but not used [-Wunused-but-set-variable]
1777 | struct bnxt_qplib_nq *nq = NULL;
| ^
drivers/infiniband/hw/bnxt_re/ib_verbs.c:1828:24: warning: variable
'nq' set but not used [-Wunused-but-set-variable]
1828 | struct bnxt_qplib_nq *nq = NULL;
| ^
2 warnings generated.
Fixes: 6b395d31146a ("RDMA/bnxt_re: Fix budget handling of notification queue")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504091055.CzgXnk4C-lkp@intel.com/
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index e14b05cd089a..063801384b2b 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -1774,10 +1774,7 @@ int bnxt_re_destroy_srq(struct ib_srq *ib_srq, struct ib_udata *udata)
ib_srq);
struct bnxt_re_dev *rdev = srq->rdev;
struct bnxt_qplib_srq *qplib_srq = &srq->qplib_srq;
- struct bnxt_qplib_nq *nq = NULL;
- if (qplib_srq->cq)
- nq = qplib_srq->cq->nq;
if (rdev->chip_ctx->modes.toggle_bits & BNXT_QPLIB_SRQ_TOGGLE_BIT) {
free_page((unsigned long)srq->uctx_srq_page);
hash_del(&srq->hash_entry);
@@ -1825,7 +1822,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq,
struct ib_udata *udata)
{
struct bnxt_qplib_dev_attr *dev_attr;
- struct bnxt_qplib_nq *nq = NULL;
struct bnxt_re_ucontext *uctx;
struct bnxt_re_dev *rdev;
struct bnxt_re_srq *srq;
@@ -1871,7 +1867,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq,
srq->qplib_srq.eventq_hw_ring_id = rdev->nqr->nq[0].ring_id;
srq->qplib_srq.sg_info.pgsize = PAGE_SIZE;
srq->qplib_srq.sg_info.pgshft = PAGE_SHIFT;
- nq = &rdev->nqr->nq[0];
if (udata) {
rc = bnxt_re_init_user_srq(rdev, pd, srq, udata);
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH rdma-rc] RDMA/bnxt_re: Remove unusable nq variable
2025-04-10 12:32 [PATCH rdma-rc] RDMA/bnxt_re: Remove unusable nq variable Leon Romanovsky
@ 2025-04-10 23:30 ` Jason Gunthorpe
2025-04-11 2:56 ` Kalesh Anakkur Purayil
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2025-04-10 23:30 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Leon Romanovsky, Kalesh AP, Kashyap Desai, kernel test robot,
linux-rdma, Selvin Xavier
On Thu, Apr 10, 2025 at 03:32:20PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Remove nq variable from bnxt_re_create_srq() and bnxt_re_destroy_srq()
> as it generates the following compilation warnings:
>
> >> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1777:24: warning: variable
> 'nq' set but not used [-Wunused-but-set-variable]
> 1777 | struct bnxt_qplib_nq *nq = NULL;
> | ^
> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1828:24: warning: variable
> 'nq' set but not used [-Wunused-but-set-variable]
> 1828 | struct bnxt_qplib_nq *nq = NULL;
> | ^
> 2 warnings generated.
>
> Fixes: 6b395d31146a ("RDMA/bnxt_re: Fix budget handling of notification queue")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504091055.CzgXnk4C-lkp@intel.com/
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 -----
> 1 file changed, 5 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH rdma-rc] RDMA/bnxt_re: Remove unusable nq variable
2025-04-10 12:32 [PATCH rdma-rc] RDMA/bnxt_re: Remove unusable nq variable Leon Romanovsky
2025-04-10 23:30 ` Jason Gunthorpe
@ 2025-04-11 2:56 ` Kalesh Anakkur Purayil
1 sibling, 0 replies; 3+ messages in thread
From: Kalesh Anakkur Purayil @ 2025-04-11 2:56 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Jason Gunthorpe, Leon Romanovsky, Kashyap Desai,
kernel test robot, linux-rdma, Selvin Xavier
[-- Attachment #1: Type: text/plain, Size: 2750 bytes --]
On Thu, Apr 10, 2025 at 6:02 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Remove nq variable from bnxt_re_create_srq() and bnxt_re_destroy_srq()
> as it generates the following compilation warnings:
>
> >> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1777:24: warning: variable
> 'nq' set but not used [-Wunused-but-set-variable]
> 1777 | struct bnxt_qplib_nq *nq = NULL;
> | ^
> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1828:24: warning: variable
> 'nq' set but not used [-Wunused-but-set-variable]
> 1828 | struct bnxt_qplib_nq *nq = NULL;
> | ^
> 2 warnings generated.
>
> Fixes: 6b395d31146a ("RDMA/bnxt_re: Fix budget handling of notification queue")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504091055.CzgXnk4C-lkp@intel.com/
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Thank you Leon for the patch, LGTM.
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index e14b05cd089a..063801384b2b 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -1774,10 +1774,7 @@ int bnxt_re_destroy_srq(struct ib_srq *ib_srq, struct ib_udata *udata)
> ib_srq);
> struct bnxt_re_dev *rdev = srq->rdev;
> struct bnxt_qplib_srq *qplib_srq = &srq->qplib_srq;
> - struct bnxt_qplib_nq *nq = NULL;
>
> - if (qplib_srq->cq)
> - nq = qplib_srq->cq->nq;
> if (rdev->chip_ctx->modes.toggle_bits & BNXT_QPLIB_SRQ_TOGGLE_BIT) {
> free_page((unsigned long)srq->uctx_srq_page);
> hash_del(&srq->hash_entry);
> @@ -1825,7 +1822,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq,
> struct ib_udata *udata)
> {
> struct bnxt_qplib_dev_attr *dev_attr;
> - struct bnxt_qplib_nq *nq = NULL;
> struct bnxt_re_ucontext *uctx;
> struct bnxt_re_dev *rdev;
> struct bnxt_re_srq *srq;
> @@ -1871,7 +1867,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq,
> srq->qplib_srq.eventq_hw_ring_id = rdev->nqr->nq[0].ring_id;
> srq->qplib_srq.sg_info.pgsize = PAGE_SIZE;
> srq->qplib_srq.sg_info.pgshft = PAGE_SHIFT;
> - nq = &rdev->nqr->nq[0];
>
> if (udata) {
> rc = bnxt_re_init_user_srq(rdev, pd, srq, udata);
> --
> 2.49.0
>
--
Regards,
Kalesh AP
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4226 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-11 2:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-10 12:32 [PATCH rdma-rc] RDMA/bnxt_re: Remove unusable nq variable Leon Romanovsky
2025-04-10 23:30 ` Jason Gunthorpe
2025-04-11 2:56 ` Kalesh Anakkur Purayil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox