[PATCH] IB/cache: update gid cache on client reregister event

[PATCH] IB/cache: update gid cache on client reregister event

[Etienne AUJAMES]

Some HCAs (e.g: ConnectX4) do not trigger a IB_EVENT_GID_CHANGE on
subnet prefix update from SM (PortInfo).

Since the d58c23c92548, the GID cache is updated exclusively on
IB_EVENT_GID_CHANGE. If this event is not emitted, the subnet prefix
in the IPoIB interface’s hardware address remains set to its default
value (0xfe80000000000000).
Then rdma_bind_addr() failed because it relies on hardware address to
find the port GID (subnet_prefix + port GUID).

This patch fixes this issue by updating the GID cache on
IB_EVENT_CLIENT_REREGISTER event (emitted on
PortInfo::ClientReregister=1).

Fixes: d58c23c92548 ("IB/core: Only update PKEY and GID caches onrespective events")
Signed-off-by: Etienne AUJAMES <eaujames@ddn.com>
---
 drivers/infiniband/core/cache.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
index 81cf3c902e81..0fc1c5bce2f0 100644
--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -1537,7 +1537,8 @@ static void ib_cache_event_task(struct work_struct *_work)
 	 * the cache.
 	 */
 	ret = ib_cache_update(work->event.device, work->event.element.port_num,
-			      work->event.event == IB_EVENT_GID_CHANGE,
+			      work->event.event == IB_EVENT_GID_CHANGE ||
+			      work->event.event == IB_EVENT_CLIENT_REREGISTER,
 			      work->event.event == IB_EVENT_PKEY_CHANGE,
 			      work->enforce_security);
 
-- 
2.51.1

RE: [PATCH] IB/cache: update gid cache on client reregister event

[Parav Pandit]

> From: Etienne AUJAMES <eaujames@ddn.com>
> Sent: 31 December 2025 06:38 PM
> 
> Some HCAs (e.g: ConnectX4) do not trigger a IB_EVENT_GID_CHANGE on
> subnet prefix update from SM (PortInfo).
> 
> Since the d58c23c92548, the GID cache is updated exclusively on
> IB_EVENT_GID_CHANGE. If this event is not emitted, the subnet prefix
> in the IPoIB interface’s hardware address remains set to its default
> value (0xfe80000000000000).
> Then rdma_bind_addr() failed because it relies on hardware address to
> find the port GID (subnet_prefix + port GUID).
>
Commit message should be referenced as d58c23c92548 ("IB/core: Only update PKEY and GID caches onrespective events").
(instead of just above commit id).
Please change the reference to full.

> This patch fixes this issue by updating the GID cache on
> IB_EVENT_CLIENT_REREGISTER event (emitted on
> PortInfo::ClientReregister=1).
> 
> Fixes: d58c23c92548 ("IB/core: Only update PKEY and GID caches onrespective events")
> Signed-off-by: Etienne AUJAMES <eaujames@ddn.com>
> ---
>  drivers/infiniband/core/cache.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
> index 81cf3c902e81..0fc1c5bce2f0 100644
> --- a/drivers/infiniband/core/cache.c
> +++ b/drivers/infiniband/core/cache.c
> @@ -1537,7 +1537,8 @@ static void ib_cache_event_task(struct work_struct *_work)
>  	 * the cache.
>  	 */
>  	ret = ib_cache_update(work->event.device, work->event.element.port_num,
> -			      work->event.event == IB_EVENT_GID_CHANGE,
> +			      work->event.event == IB_EVENT_GID_CHANGE ||
> +			      work->event.event == IB_EVENT_CLIENT_REREGISTER,
>  			      work->event.event == IB_EVENT_PKEY_CHANGE,
>  			      work->enforce_security);
> 
> --
> 2.51.1
>
Apart from above nit,
 
Reviewed-by: Parav Pandit <parav@nvidia.com>

Re: [PATCH] IB/cache: update gid cache on client reregister event

[Leon Romanovsky]

On Sat, Jan 03, 2026 at 02:11:49PM +0000, Parav Pandit wrote:
> 
> > From: Etienne AUJAMES <eaujames@ddn.com>
> > Sent: 31 December 2025 06:38 PM
> > 
> > Some HCAs (e.g: ConnectX4) do not trigger a IB_EVENT_GID_CHANGE on
> > subnet prefix update from SM (PortInfo).
> > 
> > Since the d58c23c92548, the GID cache is updated exclusively on
> > IB_EVENT_GID_CHANGE. If this event is not emitted, the subnet prefix
> > in the IPoIB interface’s hardware address remains set to its default
> > value (0xfe80000000000000).
> > Then rdma_bind_addr() failed because it relies on hardware address to
> > find the port GID (subnet_prefix + port GUID).
> >
> Commit message should be referenced as d58c23c92548 ("IB/core: Only update PKEY and GID caches onrespective events").
> (instead of just above commit id).
> Please change the reference to full.

I fixed it and applied.

Thanks

Re: [PATCH] IB/cache: update gid cache on client reregister event

[Leon Romanovsky]

On Wed, 31 Dec 2025 14:07:45 +0100, Etienne AUJAMES wrote:
> Some HCAs (e.g: ConnectX4) do not trigger a IB_EVENT_GID_CHANGE on
> subnet prefix update from SM (PortInfo).
> 
> Since the d58c23c92548, the GID cache is updated exclusively on
> IB_EVENT_GID_CHANGE. If this event is not emitted, the subnet prefix
> in the IPoIB interface’s hardware address remains set to its default
> value (0xfe80000000000000).
> Then rdma_bind_addr() failed because it relies on hardware address to
> find the port GID (subnet_prefix + port GUID).
> 
> [...]

Applied, thanks!

[1/1] IB/cache: update gid cache on client reregister event
      https://git.kernel.org/rdma/rdma/c/ddd6c8c873e912

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>