* [PATCH] RDMA/mlx5: Fix error propagation in __mlx5_ib_add
@ 2026-06-01 9:56 lirongqing
2026-06-05 17:03 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: lirongqing @ 2026-06-01 9:56 UTC (permalink / raw)
To: Leon Romanovsky, Jason Gunthorpe, linux-rdma; +Cc: Li RongQing
From: Li RongQing <lirongqing@baidu.com>
__mlx5_ib_add() currently returns -ENOMEM on any stage initialization
failure, losing the actual error code returned by the init function.
This makes it impossible for callers to distinguish between different
failure reasons (e.g. -EINVAL, -EIO, -EOPNOTSUPP) and leads to
misleading error handling.
Fix it by returning the actual error code stored in 'err'.
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
drivers/infiniband/hw/mlx5/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 6107828..c7ae46e 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -5112,7 +5112,7 @@ int __mlx5_ib_add(struct mlx5_ib_dev *dev,
if (profile->stage[i].cleanup)
profile->stage[i].cleanup(dev);
}
- return -ENOMEM;
+ return err;
}
static const struct mlx5_ib_profile pf_profile = {
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] RDMA/mlx5: Fix error propagation in __mlx5_ib_add
2026-06-01 9:56 [PATCH] RDMA/mlx5: Fix error propagation in __mlx5_ib_add lirongqing
@ 2026-06-05 17:03 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2026-06-05 17:03 UTC (permalink / raw)
To: lirongqing; +Cc: Leon Romanovsky, linux-rdma
On Mon, Jun 01, 2026 at 05:56:54AM -0400, lirongqing wrote:
> From: Li RongQing <lirongqing@baidu.com>
>
> __mlx5_ib_add() currently returns -ENOMEM on any stage initialization
> failure, losing the actual error code returned by the init function.
> This makes it impossible for callers to distinguish between different
> failure reasons (e.g. -EINVAL, -EIO, -EOPNOTSUPP) and leads to
> misleading error handling.
>
> Fix it by returning the actual error code stored in 'err'.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-05 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-01 9:56 [PATCH] RDMA/mlx5: Fix error propagation in __mlx5_ib_add lirongqing
2026-06-05 17:03 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox