From: Timothy Day <timday@thelustrecollective.com>
To: Michael Margolin <mrgolin@amazon.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org
Cc: Gal Pressman <gal.pressman@linux.dev>,
Yossi Leybovich <sleybo@amazon.com>,
Marco Elver <elver@google.com>,
Timothy Day <timday@thelustrecollective.com>
Subject: [PATCH v1 1/5] RDMA/efa: mark mmio_read seq_num as guarded by mmio_read lock
Date: Thu, 16 Jul 2026 23:16:54 -0400 [thread overview]
Message-ID: <20260717031658.477397-2-timday@thelustrecollective.com> (raw)
In-Reply-To: <20260717031658.477397-1-timday@thelustrecollective.com>
seq_num is only ever accessed while holding the mmio_read lock,
so annotate it with __guarded_by() for Clang's context analysis.
The mmio_read lock initialisation in efa_com_mmio_reg_read_init()
is marked with guard(spinlock_init). This covers the mmio_read
seq_num initialisation (later in the function) that is done
before concurrent access is possible.
Signed-off-by: Timothy Day <timday@thelustrecollective.com>
---
drivers/infiniband/hw/efa/efa_com.c | 2 +-
drivers/infiniband/hw/efa/efa_com.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/efa/efa_com.c b/drivers/infiniband/hw/efa/efa_com.c
index 7097d1c2f23df..c48971595d5ef 100644
--- a/drivers/infiniband/hw/efa/efa_com.c
+++ b/drivers/infiniband/hw/efa/efa_com.c
@@ -956,7 +956,7 @@ int efa_com_mmio_reg_read_init(struct efa_com_dev *edev)
{
struct efa_com_mmio_read *mmio_read = &edev->mmio_read;
- spin_lock_init(&mmio_read->lock);
+ guard(spinlock_init)(&mmio_read->lock);
mmio_read->read_resp =
dma_alloc_coherent(edev->dmadev, sizeof(*mmio_read->read_resp),
&mmio_read->read_resp_dma_addr, GFP_KERNEL);
diff --git a/drivers/infiniband/hw/efa/efa_com.h b/drivers/infiniband/hw/efa/efa_com.h
index 599db9d583bf5..cd1c68cdc5c43 100644
--- a/drivers/infiniband/hw/efa/efa_com.h
+++ b/drivers/infiniband/hw/efa/efa_com.h
@@ -99,7 +99,7 @@ struct efa_com_aenq {
struct efa_com_mmio_read {
struct efa_admin_mmio_req_read_less_resp *read_resp;
dma_addr_t read_resp_dma_addr;
- u16 seq_num;
+ u16 seq_num __guarded_by(&lock);
u16 mmio_read_timeout; /* usecs */
/* serializes mmio reads */
spinlock_t lock;
--
2.39.5
next prev parent reply other threads:[~2026-07-17 3:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 3:16 [PATCH v1 0/5] Support Clang context analysis for RDMA/efa Timothy Day
2026-07-17 3:16 ` Timothy Day [this message]
2026-07-17 3:16 ` [PATCH v1 2/5] RDMA/efa: mark comp_ctx_pool* as guarded by comp_ctx_lock Timothy Day
2026-07-17 3:16 ` [PATCH v1 3/5] RDMA/efa: mark admin CQ consumer state as guarded by the ACQ lock Timothy Day
2026-07-17 3:16 ` [PATCH v1 4/5] RDMA/efa: mark admin SQ producer state as guarded by the ASQ lock Timothy Day
2026-07-17 3:16 ` [PATCH v1 5/5] RDMA/efa: enable context analysis support for efa driver Timothy Day
2026-07-21 11:10 ` [PATCH v1 0/5] Support Clang context analysis for RDMA/efa Leon Romanovsky
2026-07-21 20:27 ` Timothy Day
2026-07-22 7:21 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717031658.477397-2-timday@thelustrecollective.com \
--to=timday@thelustrecollective.com \
--cc=elver@google.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox