Re: [PATCH v1 0/5] Support Clang context analysis for RDMA/efa

[Leon Romanovsky <leon@kernel.org>]

On Thu, Jul 16, 2026 at 11:16:53PM -0400, Timothy Day wrote:
> Hi,
> 
> This series adds annotations for Clang's context analysis to the
> RDMA/efa driver.
> 
> Clang context analysis was recently added in a series by Marco
> Elver [1]. This allows the compiler to validate different
> locking patterns at compile time. This series enables context
> analysis and adds new annotations.
> 
> The series was built with Clang 23 (since the minimum Clang
> version for this feature was recently bumped to 23 in 7.2+ [2])
> with CONFIG_WARN_CONTEXT_ANALYSIS enabled. I based this series
> on rdma/for-next.
> 
> I'd appreciate reviews and suggestions. I'm especially interested
> in suggestions on how we can make this easier to enable in other
> parts of the rdma subsystem.

Yes, this is precisely why I'm not rushing to apply it. It would
be far more compelling to first apply this context analysis to
drivers/infiniband/core, so we can evaluate both its benefits and
drawbacks.

On the other hand, converting drivers incrementally is the safer
approach.

Thanks

> 
> Thanks!
> 
> [1] https://lore.kernel.org/lkml/20251219154418.3592607-1-elver@google.com/
> [2] https://lore.kernel.org/all/20260515124426.2227783-1-elver@google.com/
> 
> Timothy Day (5):
>   RDMA/efa: mark mmio_read seq_num as guarded by mmio_read lock
>   RDMA/efa: mark comp_ctx_pool* as guarded by comp_ctx_lock
>   RDMA/efa: mark admin CQ consumer state as guarded by the ACQ lock
>   RDMA/efa: mark admin SQ producer state as guarded by the ASQ lock
>   RDMA/efa: enable context analysis support for efa driver
> 
>  drivers/infiniband/hw/efa/Makefile  |  2 ++
>  drivers/infiniband/hw/efa/efa_com.c | 33 +++++++++++++++++------------
>  drivers/infiniband/hw/efa/efa_com.h | 14 ++++++------
>  3 files changed, 29 insertions(+), 20 deletions(-)
> 
> -- 
> 2.39.5
>