From: sashiko-bot@kernel.org
To: "Yishai Hadas" <yishaih@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH V1 rdma-next 03/15] RDMA/vmw_pvrdma: Pin QP and SRQ rings writable to match device DMA write access
Date: Tue, 15 Sep 2026 14:21:45 +0000 [thread overview]
Message-ID: <20260915142146.3C4C81F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915140933.40580-4-yishaih@nvidia.com>
> pvrdma embeds a pvrdma_ring_state header directly inside the QP and SRQ
> ring buffers, and the hypervisor writes cons_head into that header.
> Pinning with access=0 does not force a private page copy (no
> FOLL_WRITE), so the hypervisor may write into a shared page.
>
> Pass IB_ACCESS_LOCAL_WRITE for all three rings. The SRQ ring_state is
> not currently used by the driver but is pinned writable for consistency.
>
> Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915140933.40580-1-yishaih@nvidia.com?part=3
next prev parent reply other threads:[~2026-09-15 14:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:09 [PATCH V1 rdma-next 00/15] DMA direction and mlx5 driver correctness fixes Yishai Hadas
2026-09-15 14:09 ` [PATCH V1 rdma-next 01/15] RDMA/erdma: Pin CQ buffer writable to match device DMA write access Yishai Hadas
2026-09-15 14:22 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 02/15] RDMA/hns: " Yishai Hadas
2026-09-15 14:20 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 03/15] RDMA/vmw_pvrdma: Pin QP and SRQ rings " Yishai Hadas
2026-09-15 14:21 ` sashiko-bot [this message]
2026-09-15 14:09 ` [PATCH V1 rdma-next 04/15] RDMA/umem: Reuse ib_umem_get_cq_buf_or_va() for VA-only CQ pinning Yishai Hadas
2026-09-15 14:21 ` sashiko-bot
2026-09-20 12:24 ` Leon Romanovsky
2026-09-22 7:25 ` Yishai Hadas
2026-09-15 14:09 ` [PATCH V1 rdma-next 05/15] RDMA/umem: Support an explicit DMA direction other than DMA_BIDIRECTIONAL Yishai Hadas
2026-09-15 14:21 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 06/15] RDMA/umem: Map CQ buffers DMA_FROM_DEVICE Yishai Hadas
2026-09-15 14:25 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 07/15] RDMA/umem: Derive DMA direction from IB access flags Yishai Hadas
2026-09-15 14:28 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 08/15] RDMA/mlx5: Fix mlx5_ib_dev_res_init() failure when XRC cap is absent Yishai Hadas
2026-09-15 14:24 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 09/15] RDMA/mlx5: Put resource reference in mlx5_ib_wq_event() Yishai Hadas
2026-09-15 14:25 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 10/15] RDMA/mlx5: Set WQ event handler before firmware RQ insertion Yishai Hadas
2026-09-15 14:30 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 11/15] RDMA/mlx5: Set SRQ event handler before xarray insertion Yishai Hadas
2026-09-15 14:36 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 12/15] RDMA/mlx5: Set RQ event handler for raw-packet QP Yishai Hadas
2026-09-15 14:32 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 13/15] RDMA/mlx5: Set QP event handler before firmware QPC insertion Yishai Hadas
2026-09-15 14:35 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 14/15] RDMA/mlx5: Initialize QP/RQ/SQ resource refcount before publishing it Yishai Hadas
2026-09-15 14:29 ` sashiko-bot
2026-09-15 14:09 ` [PATCH V1 rdma-next 15/15] RDMA/mlx5: Fix signed integer overflow in EQE qp_srq type shift Yishai Hadas
2026-09-15 14:31 ` sashiko-bot
2026-09-28 12:17 ` [PATCH V1 rdma-next 00/15] DMA direction and mlx5 driver correctness fixes Leon Romanovsky
2026-09-28 12:19 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915142146.3C4C81F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox