Re: [PATCH V1 rdma-next 08/15] RDMA/mlx5: Fix mlx5_ib_dev_res_init() failure when XRC cap is absent

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rdma/mlx5: missing mutex_destroy() on error path in mlx5_ib_dev_res_init()
--

commit c4290e2ba9444b4168574311394c1c28313c0387
Author: Yishai Hadas <yishaih@nvidia.com>
Subject: RDMA/mlx5: Fix mlx5_ib_dev_res_init() failure when XRC cap is absent

This commit makes XRC capabilities optional in the driver probe path. It
initializes the cq_lock and srq_lock unconditionally at the start of device
resource initialization and skips the xrcd allocation and placeholder SRQ
when XRC is absent.

> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index 373ee1f42d4ad..8b8a0f26cf19f 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
[ ... ]
> @@ -3434,8 +3443,11 @@ static int mlx5_ib_dev_res_init(struct mlx5_ib_dev *dev)
>  	struct mlx5_ib_resources *devr = &dev->devr;
>  	int ret;
>  
> +	mutex_init(&devr->cq_lock);
> +	mutex_init(&devr->srq_lock);
> +
>  	if (!MLX5_CAP_GEN(dev->mdev, xrc))
> -		return -EOPNOTSUPP;
> +		return 0;
>  
>  	ret = mlx5_cmd_xrcd_alloc(dev->mdev, &devr->xrcdn0, 0);
>  	if (ret)
> @@ -3447,9 +3459,6 @@ static int mlx5_ib_dev_res_init(struct mlx5_ib_dev *dev)
>  		return ret;
>  	}
>  
> -	mutex_init(&devr->cq_lock);
> -	mutex_init(&devr->srq_lock);
> -
>  	return 0;
>  }

[Severity: Low]
Since cq_lock and srq_lock are now unconditionally initialized at the start
of mlx5_ib_dev_res_init(), do we need to call mutex_destroy() on the error
paths if mlx5_cmd_xrcd_alloc() fails?

If either xrcd allocation fails, the function returns directly without
cleaning up the initialized mutexes. Could this missing cleanup break API
symmetry and trigger warnings in debug builds when the device memory is
subsequently freed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915140933.40580-1-yishaih@nvidia.com?part=8