From: Wentao Liang <vulab@iscas.ac.cn>
To: dsahern@kernel.org
Cc: jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, yanjun.zhu@linux.dev,
Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] RDMA/nldev: Fix ib_device reference leak in nldev_dellink()
Date: Wed, 16 Sep 2026 18:31:01 +0000 [thread overview]
Message-ID: <20260916183101.2092246-1-vulab@iscas.ac.cn> (raw)
nldev_dellink() takes a reference on the ib_device with
ib_device_get_by_index(). When the driver's dellink callback fails,
the function returns the error directly without dropping that
reference, leaking it. Call ib_device_put() on the dellink error
path before returning, matching the handling of the other error
exits in this function.
Fixes: a60e3f3d6fba ("RDMA/nldev: Add dellink function pointer")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/infiniband/core/nldev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
index 5aaba2b9746b..e4a9562313fa 100644
--- a/drivers/infiniband/core/nldev.c
+++ b/drivers/infiniband/core/nldev.c
@@ -1850,8 +1850,10 @@ static int nldev_dellink(struct sk_buff *skb, struct nlmsghdr *nlh,
mutex_lock(&nldev_dellink_mutex);
err = device->link_ops->dellink(device);
mutex_unlock(&nldev_dellink_mutex);
- if (err)
+ if (err) {
+ ib_device_put(device);
return err;
+ }
}
ib_unregister_device_and_put(device);
--
2.34.1
next reply other threads:[~2026-09-16 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 18:31 Wentao Liang [this message]
2026-09-16 18:38 ` [PATCH] RDMA/nldev: Fix ib_device reference leak in nldev_dellink() sashiko-bot
2026-09-23 8:32 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916183101.2092246-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=dsahern@kernel.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox