From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/nldev: Fix ib_device reference leak in nldev_dellink()
Date: Wed, 16 Sep 2026 18:38:46 +0000 [thread overview]
Message-ID: <20260916183847.31B501F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916183101.2092246-1-vulab@iscas.ac.cn>
> nldev_dellink() takes a reference on the ib_device with
> ib_device_get_by_index(). When the driver's dellink callback fails,
> the function returns the error directly without dropping that
> reference, leaking it. Call ib_device_put() on the dellink error
> path before returning, matching the handling of the other error
> exits in this function.
>
> Fixes: a60e3f3d6fba ("RDMA/nldev: Add dellink function pointer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916183101.2092246-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-09-16 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 18:31 [PATCH] RDMA/nldev: Fix ib_device reference leak in nldev_dellink() Wentao Liang
2026-09-16 18:38 ` sashiko-bot [this message]
2026-09-23 8:32 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916183847.31B501F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox