linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands
@ 2026-11-18 21:57 Nikhil P. Rao
  2026-11-18 22:01 ` sashiko-bot
  2026-11-22 13:14 ` Leon Romanovsky
  0 siblings, 2 replies; 3+ messages in thread
From: Nikhil P. Rao @ 2026-11-18 21:57 UTC (permalink / raw)
  To: Abhijit Gangurde, Allen Hubbe, Jason Gunthorpe, Leon Romanovsky,
	Andrew Boyer
  Cc: linux-rdma, linux-kernel, Nikhil P. Rao

Commit ec8ee714736e ("ionic: stretch heartbeat detection") notes that
firmware can take more than 2 seconds to service a device or admin
queue request, and is only expected to complete it within the ionic
command timeout of 5 seconds. The RDMA admin queue watchdog gives up
after 2 seconds, and a timeout resets the RDMA LIF, after which every
verb fails with -ENODEV. Wait 5 seconds, as ionic does for its own
admin queue.

Fixes: f3bdbd42702c ("RDMA/ionic: Create device queues to support admin operations")
Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com>
---
 drivers/infiniband/hw/ionic/ionic_admin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ionic/ionic_admin.c b/drivers/infiniband/hw/ionic/ionic_admin.c
index 0ccd869ad8e6..859893568538 100644
--- a/drivers/infiniband/hw/ionic/ionic_admin.c
+++ b/drivers/infiniband/hw/ionic/ionic_admin.c
@@ -19,7 +19,7 @@
 #define IONIC_ADMIN_BUSY_RETRY_MS	1
 
 /* admin queue will be considered failed if a command takes longer */
-#define IONIC_ADMIN_TIMEOUT	(HZ * 2)
+#define IONIC_ADMIN_TIMEOUT	(HZ * 5)
 #define IONIC_ADMIN_WARN	(HZ / 8)
 
 /* will poll for admin cq to tolerate and report from missed event */

---
base-commit: e7732ec135b501e87ab060d992b3b5f2ec4396c9
change-id: 20261118-b4-ionic-rdma-admin-timeout-3cc9f4afe247

Best regards,
--  
Nikhil P. Rao <nikhil.rao@amd.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands
  2026-11-18 21:57 [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands Nikhil P. Rao
@ 2026-11-18 22:01 ` sashiko-bot
  2026-11-22 13:14 ` Leon Romanovsky
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-18 22:01 UTC (permalink / raw)
  To: Nikhil P. Rao; +Cc: linux-rdma

> Commit ec8ee714736e ("ionic: stretch heartbeat detection") notes that
> firmware can take more than 2 seconds to service a device or admin
> queue request, and is only expected to complete it within the ionic
> command timeout of 5 seconds. The RDMA admin queue watchdog gives up
> after 2 seconds, and a timeout resets the RDMA LIF, after which every
> verb fails with -ENODEV. Wait 5 seconds, as ionic does for its own
> admin queue.
> 
> Fixes: f3bdbd42702c ("RDMA/ionic: Create device queues to support admin operations")
> Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-b4-ionic-rdma-admin-timeout-v1-1-39536999a3e4@amd.com?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands
  2026-11-18 21:57 [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands Nikhil P. Rao
  2026-11-18 22:01 ` sashiko-bot
@ 2026-11-22 13:14 ` Leon Romanovsky
  1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2026-11-22 13:14 UTC (permalink / raw)
  To: Nikhil P. Rao
  Cc: Abhijit Gangurde, Allen Hubbe, Jason Gunthorpe, Andrew Boyer,
	linux-rdma, linux-kernel

On Wed, Nov 18, 2026 at 09:57:52PM +0000, Nikhil P. Rao wrote:
> Commit ec8ee714736e ("ionic: stretch heartbeat detection") notes that
> firmware can take more than 2 seconds to service a device or admin
> queue request, and is only expected to complete it within the ionic
> command timeout of 5 seconds. The RDMA admin queue watchdog gives up
> after 2 seconds, and a timeout resets the RDMA LIF, after which every
> verb fails with -ENODEV. Wait 5 seconds, as ionic does for its own
> admin queue.

Is this a real, user-visible bug, or merely a nice-to-have improvement?

Thanks

> 
> Fixes: f3bdbd42702c ("RDMA/ionic: Create device queues to support admin operations")
> Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com>
> ---
>  drivers/infiniband/hw/ionic/ionic_admin.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/ionic/ionic_admin.c b/drivers/infiniband/hw/ionic/ionic_admin.c
> index 0ccd869ad8e6..859893568538 100644
> --- a/drivers/infiniband/hw/ionic/ionic_admin.c
> +++ b/drivers/infiniband/hw/ionic/ionic_admin.c
> @@ -19,7 +19,7 @@
>  #define IONIC_ADMIN_BUSY_RETRY_MS	1
>  
>  /* admin queue will be considered failed if a command takes longer */
> -#define IONIC_ADMIN_TIMEOUT	(HZ * 2)
> +#define IONIC_ADMIN_TIMEOUT	(HZ * 5)
>  #define IONIC_ADMIN_WARN	(HZ / 8)
>  
>  /* will poll for admin cq to tolerate and report from missed event */
> 
> ---
> base-commit: e7732ec135b501e87ab060d992b3b5f2ec4396c9
> change-id: 20261118-b4-ionic-rdma-admin-timeout-3cc9f4afe247
> 
> Best regards,
> --  
> Nikhil P. Rao <nikhil.rao@amd.com>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-22 13:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 21:57 [PATCH rdma-rc] RDMA/ionic: Wait the device command timeout for admin queue commands Nikhil P. Rao
2026-11-18 22:01 ` sashiko-bot
2026-11-22 13:14 ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).