From: Bart Van Assche <bvanassche@acm.org>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leonro@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/4] siw: Increase DMA max_segment_size parameter
Date: Mon, 21 Oct 2019 06:53:29 -0700 [thread overview]
Message-ID: <2afaa09e-48a8-5189-026d-577b0f5d8ac9@acm.org> (raw)
In-Reply-To: <OF471AECA2.EB2C94E3-ON0025849A.0033B64B-0025849A.0034BC19@notes.na.collabserv.com>
On 10/21/19 2:36 AM, Bernard Metzler wrote:
> Why don't we make device_dma_parameters siw_dma_params
> just a const in siw_main.c? Having it per siw_device suggests
> more flexibility than we actually need and support? Probably
> true as well for rxe driver. This is all driver specific.
>
> Independent of this current patch, probably even true for
> siw_device.attrs. We do not have those capabilities siw
> device specific, but just siw driver specific.
Hi Bernard,
The dma_parms pointer in struct device has not been declared const.
Assigning a pointer to a const structure to the dma_parms member of
struct device would trigger a compiler warning. I think everyone wants
to keep the RDMA code free from compiler warnings.
Thanks,
Bart.
prev parent reply other threads:[~2019-10-21 13:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 2:10 [PATCH 0/4] Fixes related to the DMA max_segment_size parameter Bart Van Assche
2019-10-21 2:10 ` [PATCH 1/4] RDMA/core: Fix ib_dma_max_seg_size() Bart Van Assche
2019-10-21 14:09 ` Jason Gunthorpe
2019-10-21 15:03 ` Bart Van Assche
2019-10-21 15:27 ` Jason Gunthorpe
2019-10-21 15:56 ` Bart Van Assche
2019-10-21 2:10 ` [PATCH 2/4] RDMA/core: Set DMA parameters correctly Bart Van Assche
2019-10-21 14:10 ` Jason Gunthorpe
2019-10-21 16:26 ` Bart Van Assche
2019-10-21 17:44 ` Saleem, Shiraz
2019-10-21 18:10 ` Bart Van Assche
2019-10-21 20:32 ` Saleem, Shiraz
2019-10-22 14:40 ` Jason Gunthorpe
2019-10-22 22:11 ` Bart Van Assche
2019-10-21 2:10 ` [PATCH 3/4] rdma_rxe: Increase DMA max_segment_size parameter Bart Van Assche
2019-10-21 2:10 ` [PATCH 4/4] siw: " Bart Van Assche
2019-10-21 9:36 ` Bernard Metzler
2019-10-21 13:53 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2afaa09e-48a8-5189-026d-577b0f5d8ac9@acm.org \
--to=bvanassche@acm.org \
--cc=BMT@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox