Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Xiao Yang <yangx.jy@fujitsu.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode
Date: Fri, 8 Apr 2022 14:34:00 -0500	[thread overview]
Message-ID: <5295c51f-91a3-c9a4-2811-03f13c71205e@gmail.com> (raw)
In-Reply-To: <20220408182617.GA3648486@nvidia.com>

On 4/8/22 13:26, Jason Gunthorpe wrote:
> On Fri, Apr 08, 2022 at 11:30:29AM +0800, Xiao Yang wrote:
>> Current rxe_requester() doesn't generate a completion when processing an
>> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
>> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
>> using the new opcode can reproduce this issue. Fix the issue by calling
>> "goto err;".
>>
>> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
>> ---
>>  drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Fixes line?
> 
> Jason

That would be 

Fixes: 8700e3e7c485 ("Soft RoCE (RXE) - The software RoCE driver")


Been there forever.

  reply	other threads:[~2022-04-08 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  3:30 [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode Xiao Yang
2022-04-08 18:11 ` Bob Pearson
2022-04-08 18:26 ` Jason Gunthorpe
2022-04-08 19:34   ` Bob Pearson [this message]
2022-04-10 11:29     ` yangx.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5295c51f-91a3-c9a4-2811-03f13c71205e@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yangx.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox