Re: [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode

["yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>]

On 2022/4/9 3:34, Bob Pearson wrote:
> On 4/8/22 13:26, Jason Gunthorpe wrote:
>> On Fri, Apr 08, 2022 at 11:30:29AM +0800, Xiao Yang wrote:
>>> Current rxe_requester() doesn't generate a completion when processing an
>>> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
>>> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
>>> using the new opcode can reproduce this issue. Fix the issue by calling
>>> "goto err;".
>>>
>>> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
>>> ---
>>>   drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Fixes line?
>>
>> Jason
> 
> That would be
> 
> Fixes: 8700e3e7c485 ("Soft RoCE (RXE) - The software RoCE driver")
> 

Right, I will send v2 patch with the Fixes line.

Best Regards,
Xiao Yang
> 
> Been there forever.