Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: "Margolin, Michael" <mrgolin@amazon.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>, <sleybo@amazon.com>,
	<matua@amazon.com>, <gal.pressman@linux.dev>,
	Firas Jahjah <firasj@amazon.com>,
	Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next] RDMA/core: Fix best page size finding when it can cross SG entries
Date: Mon, 17 Feb 2025 10:40:47 +0200	[thread overview]
Message-ID: <5c7bf57a-847b-4425-8e53-9e80c87e783e@amazon.com> (raw)
In-Reply-To: <20250216080724.GS17863@unreal>


On 2/16/2025 10:07 AM, Leon Romanovsky wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Thu, Feb 13, 2025 at 02:12:42PM -0400, Jason Gunthorpe wrote:
>> On Thu, Feb 13, 2025 at 07:55:17PM +0200, Leon Romanovsky wrote:
>>> On Thu, Feb 13, 2025 at 01:40:43PM -0400, Jason Gunthorpe wrote:
>>>> On Thu, Feb 13, 2025 at 07:35:10PM +0200, Leon Romanovsky wrote:
>>>>
>>>>> Initially curr_base is 0xFF.....FF and curr_len is 0.
>>>> curr base can't be so unaligned can it?
>>> It is only for first iteration where it is compared with
>>> sg_dma_address(), immediately after that it is overwritten.
>> But this is all working with inherently page aligned stuff, cur_base +
>> len1 + len2 + len3 + len_n should be page aligned for interior segments..
> This is unknown to static code analyze tools. I'm not concerned about
> logical change, but about possible static code analyze failures.
>
> Thanks

OK, I'll edit the patch to make sure it doesn't produce any SA failures.

Michael


  reply	other threads:[~2025-02-17  8:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-09 14:26 [PATCH for-next] RDMA/core: Fix best page size finding when it can cross SG entries Michael Margolin
2025-02-13 12:51 ` Leon Romanovsky
2025-02-13 14:04   ` Jason Gunthorpe
2025-02-13 14:30     ` Margolin, Michael
2025-02-13 14:42       ` Jason Gunthorpe
2025-02-13 17:25         ` Margolin, Michael
2025-02-13 17:35         ` Leon Romanovsky
2025-02-13 17:40           ` Jason Gunthorpe
2025-02-13 17:55             ` Leon Romanovsky
2025-02-13 18:12               ` Jason Gunthorpe
2025-02-14  5:55                 ` Leon Romanovsky
2025-02-14 15:33                   ` Jason Gunthorpe
2025-02-16  8:07                 ` Leon Romanovsky
2025-02-17  8:40                   ` Margolin, Michael [this message]
2025-02-13 12:53 ` Leon Romanovsky
2025-02-14  6:57   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c7bf57a-847b-4425-8e53-9e80c87e783e@amazon.com \
    --to=mrgolin@amazon.com \
    --cc=firasj@amazon.com \
    --cc=gal.pressman@linux.dev \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=sleybo@amazon.com \
    --cc=ynachum@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox