From: "Margolin, Michael" <mrgolin@amazon.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>, <linux-rdma@vger.kernel.org>,
<sleybo@amazon.com>, <matua@amazon.com>, <gal.pressman@linux.dev>,
"Firas Jahjah" <firasj@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next] RDMA/core: Fix best page size finding when it can cross SG entries
Date: Thu, 13 Feb 2025 19:25:41 +0200 [thread overview]
Message-ID: <fffa6c21-c5d6-46f7-8090-f26c1c72ce55@amazon.com> (raw)
In-Reply-To: <20250213144219.GB3754072@nvidia.com>
On 2/13/2025 4:42 PM, Jason Gunthorpe wrote:
> I wonder if we should try to make a overflow.h helper for these kinds
> of problems.
>
> /* Check if a + n == b, failing if a+n overflows */
> check_consecutive(a, n, b)
>
> ?
>
> It is a fairly common problem
>
> I suggest to take the patch as it originally was and try to propose
> the above helper?
Sounds reasonable, I can propose such check helpers.
Michael
next prev parent reply other threads:[~2025-02-13 17:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 14:26 [PATCH for-next] RDMA/core: Fix best page size finding when it can cross SG entries Michael Margolin
2025-02-13 12:51 ` Leon Romanovsky
2025-02-13 14:04 ` Jason Gunthorpe
2025-02-13 14:30 ` Margolin, Michael
2025-02-13 14:42 ` Jason Gunthorpe
2025-02-13 17:25 ` Margolin, Michael [this message]
2025-02-13 17:35 ` Leon Romanovsky
2025-02-13 17:40 ` Jason Gunthorpe
2025-02-13 17:55 ` Leon Romanovsky
2025-02-13 18:12 ` Jason Gunthorpe
2025-02-14 5:55 ` Leon Romanovsky
2025-02-14 15:33 ` Jason Gunthorpe
2025-02-16 8:07 ` Leon Romanovsky
2025-02-17 8:40 ` Margolin, Michael
2025-02-13 12:53 ` Leon Romanovsky
2025-02-14 6:57 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffa6c21-c5d6-46f7-8090-f26c1c72ce55@amazon.com \
--to=mrgolin@amazon.com \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox