Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: kensanya  <kensanya@163.com>
To: "Bart Van Assche" <bvanassche@acm.org>
Cc: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
	jgg@ziepe.ca, leon@kernel.org
Subject: Re:Re: [QUESTION] RDMA/srpt: is target_send_busy() safe before target_init_cmd()?
Date: Mon, 20 Jul 2026 10:10:34 +0800 (CST)	[thread overview]
Message-ID: <63578cf8.1b55.19f7d4a126c.Coremail.kensanya@163.com> (raw)
In-Reply-To: <9f5875f8-2ab0-4272-a8a3-d6cf711978b5@acm.org>



At 2026-07-18 01:59:35, "Bart Van Assche" <bvanassche@acm.org> wrote:
>On 7/16/26 7:54 PM, kensanya@163.com wrote:
>> 1. Is calling target_send_busy() before target_init_cmd() intentional /
>>     known-safe?
>
>I think that's a bug.
>
>> 2. If not, should ib_srpt.c send a fabric-local SRP_RSP BUSY (or otherwise
>>     free the send ioctx) when se_tfo is unset, and keep target_send_busy()
>>     only for the post-init failure path?
>
>How about swapping the order of the target_init_cmd() and
>srp_get_desc_tbl() calls and initializing .data_length and 
>.data_direction after the srp_get_desc_tbl() call?
>
>Thanks,
>
>Bart.

Hi，
Bart

This plan involves fewer changes. Perhaps I could submit a fix patch.

Thanks
TanZheng


  reply	other threads:[~2026-07-20  2:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  2:54 [QUESTION] RDMA/srpt: is target_send_busy() safe before target_init_cmd()? kensanya
2026-07-17 17:59 ` Bart Van Assche
2026-07-20  2:10   ` kensanya [this message]
2026-07-20  3:05     ` kensanya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63578cf8.1b55.19f7d4a126c.Coremail.kensanya@163.com \
    --to=kensanya@163.com \
    --cc=bvanassche@acm.org \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox