From: Bart Van Assche <bvanassche@acm.org>
To: kensanya@163.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org
Cc: jgg@ziepe.ca, leon@kernel.org
Subject: Re: [QUESTION] RDMA/srpt: is target_send_busy() safe before target_init_cmd()?
Date: Fri, 17 Jul 2026 10:59:35 -0700 [thread overview]
Message-ID: <9f5875f8-2ab0-4272-a8a3-d6cf711978b5@acm.org> (raw)
In-Reply-To: <20260717025402.64054-1-kensanya@163.com>
On 7/16/26 7:54 PM, kensanya@163.com wrote:
> 1. Is calling target_send_busy() before target_init_cmd() intentional /
> known-safe?
I think that's a bug.
> 2. If not, should ib_srpt.c send a fabric-local SRP_RSP BUSY (or otherwise
> free the send ioctx) when se_tfo is unset, and keep target_send_busy()
> only for the post-init failure path?
How about swapping the order of the target_init_cmd() and
srp_get_desc_tbl() calls and initializing .data_length and
.data_direction after the srp_get_desc_tbl() call?
Thanks,
Bart.
next prev parent reply other threads:[~2026-07-17 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 2:54 [QUESTION] RDMA/srpt: is target_send_busy() safe before target_init_cmd()? kensanya
2026-07-17 17:59 ` Bart Van Assche [this message]
2026-07-20 2:10 ` kensanya
2026-07-20 3:05 ` kensanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f5875f8-2ab0-4272-a8a3-d6cf711978b5@acm.org \
--to=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=kensanya@163.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox