From: wangyufen <wangyufen@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <bvanassche@acm.org>, <jgg@ziepe.ca>, <leon@kernel.org>,
<dennis.dalessandro@cornelisnetworks.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bart.vanassche@wdc.com>, <easwar.hariharan@intel.com>
Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in srp_parse_options()
Date: Sat, 26 Nov 2022 21:19:50 +0800 [thread overview]
Message-ID: <6c9c2a4a-844f-70d6-8f93-1f13a0612bf3@huawei.com> (raw)
In-Reply-To: <Y4IAky87PxC/J7lr@smile.fi.intel.com>
在 2022/11/26 20:03, Andy Shevchenko 写道:
> On Sat, Nov 26, 2022 at 02:02:14PM +0200, Andy Shevchenko wrote:
>> On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote:
>
> ...
>
>>> target->scsi_host->can_queue);
>>
>> The below can't be like this, right?
>>
>>> +out_with_einval:
>>> + ret = -EINVAL;
>>> out:
>>> kfree(options);
>>> return ret;
>
> One option is:
>
> out:
> kfree(options);
> return ret;
>
> out_with_einval:
> ret = -EINVAL;
> goto out;
I got it.
Thanks!
>
>
next prev parent reply other threads:[~2022-11-26 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 3:35 [PATCH v2 1/2] RDMA/hfi1: Fix error return code in parse_platform_config() Wang Yufen
2022-11-26 3:35 ` [PATCH v2 2/2] RDMA/srp: Fix error return code in srp_parse_options() Wang Yufen
2022-11-26 12:02 ` Andy Shevchenko
2022-11-26 12:03 ` Andy Shevchenko
2022-11-26 13:19 ` wangyufen [this message]
2022-11-26 13:19 ` wangyufen
2022-11-26 12:04 ` [PATCH v2 1/2] RDMA/hfi1: Fix error return code in parse_platform_config() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9c2a4a-844f-70d6-8f93-1f13a0612bf3@huawei.com \
--to=wangyufen@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bart.vanassche@wdc.com \
--cc=bvanassche@acm.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=easwar.hariharan@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox