* [PATCH rdma-rc] RDMA/core: Require admin capabilities to set system parameters
@ 2023-10-04 18:17 Leon Romanovsky
2023-10-05 4:44 ` Parav Pandit
2023-10-05 17:02 ` Leon Romanovsky
0 siblings, 2 replies; 3+ messages in thread
From: Leon Romanovsky @ 2023-10-04 18:17 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: Leon Romanovsky, linux-rdma, Parav Pandit
From: Leon Romanovsky <leonro@nvidia.com>
Like any other set command, require admin permissions to do it.
Cc: stable@vger.kernel.org
Fixes: 2b34c5580226 ("RDMA/core: Add command to set ib_core device net namspace sharing mode")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/core/nldev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
index 5c805fa6187f..87b8cd657fb3 100644
--- a/drivers/infiniband/core/nldev.c
+++ b/drivers/infiniband/core/nldev.c
@@ -2595,6 +2595,7 @@ static const struct rdma_nl_cbs nldev_cb_table[RDMA_NLDEV_NUM_OPS] = {
},
[RDMA_NLDEV_CMD_SYS_SET] = {
.doit = nldev_set_sys_set_doit,
+ .flags = RDMA_NL_ADMIN_PERM,
},
[RDMA_NLDEV_CMD_STAT_SET] = {
.doit = nldev_stat_set_doit,
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH rdma-rc] RDMA/core: Require admin capabilities to set system parameters
2023-10-04 18:17 [PATCH rdma-rc] RDMA/core: Require admin capabilities to set system parameters Leon Romanovsky
@ 2023-10-05 4:44 ` Parav Pandit
2023-10-05 17:02 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Parav Pandit @ 2023-10-05 4:44 UTC (permalink / raw)
To: Leon Romanovsky, Jason Gunthorpe
Cc: Leon Romanovsky, linux-rdma@vger.kernel.org
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Wednesday, October 4, 2023 11:48 PM
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Like any other set command, require admin permissions to do it.
>
> Cc: stable@vger.kernel.org
> Fixes: 2b34c5580226 ("RDMA/core: Add command to set ib_core device net
> namspace sharing mode")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/nldev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
> index 5c805fa6187f..87b8cd657fb3 100644
> --- a/drivers/infiniband/core/nldev.c
> +++ b/drivers/infiniband/core/nldev.c
> @@ -2595,6 +2595,7 @@ static const struct rdma_nl_cbs
> nldev_cb_table[RDMA_NLDEV_NUM_OPS] = {
> },
> [RDMA_NLDEV_CMD_SYS_SET] = {
> .doit = nldev_set_sys_set_doit,
> + .flags = RDMA_NL_ADMIN_PERM,
> },
> [RDMA_NLDEV_CMD_STAT_SET] = {
> .doit = nldev_stat_set_doit,
> --
> 2.41.0
Reviewed-by: Parav Pandit <parav@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH rdma-rc] RDMA/core: Require admin capabilities to set system parameters
2023-10-04 18:17 [PATCH rdma-rc] RDMA/core: Require admin capabilities to set system parameters Leon Romanovsky
2023-10-05 4:44 ` Parav Pandit
@ 2023-10-05 17:02 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2023-10-05 17:02 UTC (permalink / raw)
To: Jason Gunthorpe, Leon Romanovsky
Cc: linux-rdma, Parav Pandit, Leon Romanovsky
On Wed, 04 Oct 2023 21:17:49 +0300, Leon Romanovsky wrote:
> Like any other set command, require admin permissions to do it.
>
>
Applied, thanks!
[1/1] RDMA/core: Require admin capabilities to set system parameters
https://git.kernel.org/rdma/rdma/c/c38d23a54445f9
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-05 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-04 18:17 [PATCH rdma-rc] RDMA/core: Require admin capabilities to set system parameters Leon Romanovsky
2023-10-05 4:44 ` Parav Pandit
2023-10-05 17:02 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox