From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: gang.yan@linux.dev, zyjzyj2000@gmail.com,
"yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>
Cc: linux-rdma@vger.kernel.org, Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH net 2/2] DO-NOT-MERGE: selftest: add rxe mr_check_range() overflow reproducer
Date: Wed, 5 Aug 2026 08:56:30 -0700 [thread overview]
Message-ID: <79542318-04be-44f0-947d-7a02e093665f@linux.dev> (raw)
In-Reply-To: <9e00be256dee0ad1d163ed0e26d2c15b238efc68@linux.dev>
在 2026/8/5 0:47, gang.yan@linux.dev 写道:
>> Thank you for the clarification.
>>
>> I agree that we can drop the selftest patch. My original suggestion was mainly to make sure we have proper coverage for this issue, but after considering your explanation, I think adding a standalone selftest for this particular case may not be necessary.
>>
>> The bug fix itself is the important part, and keeping the selftest out will also avoid adding a test case that may not provide much long-term value.
> Hi Yanjun,
>
> Thank you for your feedback.
>
> No offense at all.
>
> Regarding Patch 1 (the actual fix), I noticed that it hasn't received a Reviewed-by
> or any further comments yet. As a newcomer to the RDMA community, I just want to
> make sure I'm following the right process. Should I proactively send a v2 with only
> the fix (now that the selftest is removed), or is it preferable to wait for more
> reviews on the current version before resending?
>
> Please don't take this as a nudge — I'm genuinely asking because I want to avoid
> missing any step that I should be taking on my side. I'm happy to wait if
> that's the usual practice.
Hi Gang,
I think it's fine to send a v2 with only the fix. There's no need to
include the selftest in this series anymore.
If you'd like, you can also add the following since I have reviewed this
commit and made tests in my local host. It can pass my local testcases.
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Thanks,
Zhu Yanjun
>
> Thanks
> Gang
--
Best Regards,
Yanjun.Zhu
next prev parent reply other threads:[~2026-08-05 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 9:11 [PATCH net 0/2] RDMA/rxe: fix mr_check_range() iova overflow (OOB) Gang Yan
2026-07-28 9:11 ` [PATCH net 1/2] RDMA/rxe: Fix integer overflow in mr_check_range() leading to OOB access Gang Yan
2026-07-28 9:11 ` [PATCH net 2/2] DO-NOT-MERGE: selftest: add rxe mr_check_range() overflow reproducer Gang Yan
2026-08-02 22:09 ` Zhu Yanjun
2026-08-02 22:28 ` Zhu Yanjun
2026-08-03 1:49 ` gang.yan
2026-08-04 2:17 ` Zhu Yanjun
2026-08-05 7:47 ` gang.yan
2026-08-05 15:56 ` Zhu Yanjun [this message]
2026-07-30 5:15 ` [PATCH net 0/2] RDMA/rxe: fix mr_check_range() iova overflow (OOB) Zhu Yanjun
2026-08-01 9:27 ` gang.yan
2026-08-02 22:21 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79542318-04be-44f0-947d-7a02e093665f@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=gang.yan@linux.dev \
--cc=linux-rdma@vger.kernel.org \
--cc=yangang@kylinos.cn \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).