Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: gang.yan@linux.dev, Zhu Yanjun <yanjun.zhu@linux.dev>,
	zyjzyj2000@gmail.com
Cc: linux-rdma@vger.kernel.org, Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH net 2/2] DO-NOT-MERGE: selftest: add rxe mr_check_range() overflow reproducer
Date: Mon, 3 Aug 2026 19:17:36 -0700	[thread overview]
Message-ID: <9daf85d5-e12d-4498-86e6-aa6180a91df5@linux.dev> (raw)
In-Reply-To: <393f97fc5e5c042d5bd62231f96fae0b527a58d0@linux.dev>


在 2026/8/2 18:49, gang.yan@linux.dev 写道:
> August 3, 2026 at 6:28 AM, "Zhu Yanjun" <yanjun.zhu@linux.dev mailto:yanjun.zhu@linux.dev?to=%22Zhu%20Yanjun%22%20%3Cyanjun.zhu%40linux.dev%3E > wrote:
>
>
>>>   Thanks a lot. When I run rdma selftests. I got the following:
>>>   "
>>>   # Warning: file rxe_mr_overflow.sh is not executable
>>>   "
>>>   You need to make rxe_mr_overflow.sh executable.
>>>
>> After this testcase is run, please remove this bin file rxe_mr_overflow in tools/testing/selftests/rdma.
>>
>> Thanks a lot.
> Hi Yanjun,
>
> Thank you for your reply.
>
> Regarding the selftest patch, my initial thought was that the selftest does not need to cover this particular
> issue separately, which is why I added the DO-NOT-MERGE tag.
>
> However, after reading your feedback, I would like to clarify your suggestion: do you mean that I should
> integrate the attached rxe_mr_overflow.c into the selftest suite? Or is there a different way you would
> recommend?  If you fell OK, I would prefer to drop this selftest patch entirely.
>
> Please let me know your preferred approach. I'm happy to adjust it. Thanks again for your guidance!
>
> Best regards,


Thank you for the clarification.

I agree that we can drop the selftest patch. My original suggestion was 
mainly to make sure we have proper coverage for this issue, but after 
considering your explanation, I think adding a standalone selftest for 
this particular case may not be necessary.

The bug fix itself is the important part, and keeping the selftest out 
will also avoid adding a test case that may not provide much long-term 
value.

Please feel free to remove the selftest patch and keep the fix patch only.

Thanks again for your work and for discussing this with me.

Best regards,
Zhu Yanjun


> Gang
>
>> Zhu Yanjun
>>
-- 
Best Regards,
Yanjun.Zhu


  reply	other threads:[~2026-08-04  2:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  9:11 [PATCH net 0/2] RDMA/rxe: fix mr_check_range() iova overflow (OOB) Gang Yan
2026-07-28  9:11 ` [PATCH net 1/2] RDMA/rxe: Fix integer overflow in mr_check_range() leading to OOB access Gang Yan
2026-07-28  9:11 ` [PATCH net 2/2] DO-NOT-MERGE: selftest: add rxe mr_check_range() overflow reproducer Gang Yan
2026-08-02 22:09   ` Zhu Yanjun
2026-08-02 22:28     ` Zhu Yanjun
2026-08-03  1:49       ` gang.yan
2026-08-04  2:17         ` Zhu Yanjun [this message]
2026-08-05  7:47           ` gang.yan
2026-08-05 15:56             ` Zhu Yanjun
2026-07-30  5:15 ` [PATCH net 0/2] RDMA/rxe: fix mr_check_range() iova overflow (OOB) Zhu Yanjun
2026-08-01  9:27   ` gang.yan
2026-08-02 22:21     ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9daf85d5-e12d-4498-86e6-aa6180a91df5@linux.dev \
    --to=yanjun.zhu@linux.dev \
    --cc=gang.yan@linux.dev \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yangang@kylinos.cn \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox