Re: [PATCH] vmw_pvrdma: Avoid rounding up of sge count to power of 2

[Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>]

On 2/15/18 11:22 PM, Leon Romanovsky wrote:
> On Thu, Feb 15, 2018 at 04:39:52PM -0800, Adit Ranadive wrote:
>> Creation of resources can fail if the rounding up exceeds
>> provider supported values.
>>
>> Fixes: 4c8ed14eb6b7 ("vmw_pvrdma: Add SRQ support")
>> Reviewed-by: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
>> Reviewed-by: Nitish Bhat <bnitish-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
>> Cc: stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org
>> ---
>>  providers/vmw_pvrdma/qp.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/providers/vmw_pvrdma/qp.c b/providers/vmw_pvrdma/qp.c
>> index efcc99b..4b9f897 100644
>> --- a/providers/vmw_pvrdma/qp.c
>> +++ b/providers/vmw_pvrdma/qp.c
>> @@ -113,7 +113,7 @@ struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd,
>>  	int ret;
>>
>>  	attr->attr.max_wr = align_next_power2(max_t(uint32_t, 1U, attr->attr.max_wr));
>> -	attr->attr.max_sge = align_next_power2(max_t(uint32_t, 1U, attr->attr.max_sge));
>> +	attr->attr.max_sge = max_t(uint32_t, 1U, attr->attr.max_sge);
> 
> One of two: or your commit message is not correct and you should mention
> that align_next_power2() is not needed, or your code is incorrect,
> because user can provide large enough number and this call will fail
> anyway.

Sorry, that's a terrible commit message. Yeah the align_next_power2 is extraneous.
Will send v1 out with updated message.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html