[PATCH] infiniband: iser: remove the unnecessary var

[PATCH] infiniband: iser: remove the unnecessary var

[lijun]

From c1129a053b33e6f85be3d7a26bf0dbb9bac64949 Mon Sep 17 00:00:00 2001
From: Li Jun <lijun01@kylinos.cn>
Date: Wed, 4 Jun 2025 16:45:10 +0800
Subject: [PATCH] infiniband: iser: remove the unnecessary var

In iscsi_iser_mtask_xmit, may return iser_send_control(conn, task)
directly,so del 'error'.

Signed-off-by: Li Jun <lijun01@kylinos.cn>
---
 drivers/infiniband/ulp/iser/iscsi_iser.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-
)                                                                      
                                                  

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c
b/drivers/infiniband/ulp/iser/iscsi_iser.c
index a5be6f1ba12b..2e3c0516ce8f 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -267,19 +267,15 @@ static int iscsi_iser_task_init(struct iscsi_task
*task)
 static int iscsi_iser_mtask_xmit(struct iscsi_conn *conn,
                 struct iscsi_task *task)
 {
-   int error = 0;
-
    iser_dbg("mtask xmit [cid %d itt 0x%x]\n", conn->id, task->itt);

-   error = iser_send_control(conn, task);
-
    /* since iser xmits control with zero copy, tasks can not be
recycled
     * right after sending them.
     * The recycling scheme is based on whether a response is expected
     * - if yes, the task is recycled at iscsi_complete_pdu
     * - if no,  the task is recycled at iser_snd_completion
     */
-   return error;
+   return iser_send_control(conn, task);
 }

 static int iscsi_iser_task_xmit_unsol_data(struct iscsi_conn *conn,
-- 
2.25.1

Re: [PATCH] infiniband: iser: remove the unnecessary var

[Max Gurtovoy]

On 04/06/2025 12:12, lijun wrote:
>  From c1129a053b33e6f85be3d7a26bf0dbb9bac64949 Mon Sep 17 00:00:00 2001
> From: Li Jun <lijun01@kylinos.cn>
> Date: Wed, 4 Jun 2025 16:45:10 +0800

seems like something is wrong with your mailer.

try using "git send-mail"


> Subject: [PATCH] infiniband: iser: remove the unnecessary var

IB/iser: remove unnecessary local variable


>
> In iscsi_iser_mtask_xmit, may return iser_send_control(conn, task)
> directly,so del 'error'.

The 'error' variable is no longer needed, as iscsi_iser_mtask_xmit can 
return the result of iser_send_control(conn, task) directly.


>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
>   drivers/infiniband/ulp/iser/iscsi_iser.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-
> )
>                                                    
>
> diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c
> b/drivers/infiniband/ulp/iser/iscsi_iser.c
> index a5be6f1ba12b..2e3c0516ce8f 100644
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.c
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
> @@ -267,19 +267,15 @@ static int iscsi_iser_task_init(struct iscsi_task
> *task)
>   static int iscsi_iser_mtask_xmit(struct iscsi_conn *conn,
>                   struct iscsi_task *task)
>   {
> -   int error = 0;
> -
>      iser_dbg("mtask xmit [cid %d itt 0x%x]\n", conn->id, task->itt);
>
> -   error = iser_send_control(conn, task);
> -
>      /* since iser xmits control with zero copy, tasks can not be
> recycled
>       * right after sending them.
>       * The recycling scheme is based on whether a response is expected
>       * - if yes, the task is recycled at iscsi_complete_pdu
>       * - if no,  the task is recycled at iser_snd_completion
>       */
> -   return error;
> +   return iser_send_control(conn, task);
>   }
>
>   static int iscsi_iser_task_xmit_unsol_data(struct iscsi_conn *conn,

change looks good to me, please fix the above in v2.

Acked-by: Max Gurtovoy <mgurtovoy@nvidia.com>