Re: [PATCH for-next 0/8] Some fixes from hns

Re: [PATCH for-next 0/8] Some fixes from hns

[Jason Gunthorpe]

On Mon, Jun 24, 2019 at 07:47:44PM +0800, Lijun Ou wrote:
> Here are some bug fixes as well code optimization.
> 
> Lang Cheng (3):
>   RDMA/hns: Set reset flag when hw resetting
>   RDMA/hns: Use %pK format pointer print
>   RDMA/hns: Clean up unnecessary variable initialization
> 
> Lijun Ou (1):
>   RDMA/hns: Bugfix for cleaning mtr
> 
> Xi Wang (1):
>   RDMA/hns: Fixs hw access invalid dma memory error
> 
> Yangyang Li (1):
>   RDMA/hns: Modify ba page size for cqe
> 
> chenglang (1):
>   RDMA/hns: Fixup qp release bug
> 
> o00290482 (1):
>   RDMA/hns: Bugfix for calculating qp buffer size
> 
>  drivers/infiniband/hw/hns/hns_roce_cmd.c   |  2 +-
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c |  4 +++-
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c |  9 +++++----
>  drivers/infiniband/hw/hns/hns_roce_main.c  |  2 +-
>  drivers/infiniband/hw/hns/hns_roce_pd.c    |  2 +-
>  drivers/infiniband/hw/hns/hns_roce_qp.c    | 13 ++++---------
>  6 files changed, 15 insertions(+), 17 deletions(-)
>

Applied to for-next, thanks

Jason

Re: [PATCH for-next 5/8] RDMA/hns: Bugfix for calculating qp buffer size

[oulijun]

在 2019/6/24 19:47, Lijun Ou 写道:
> From: o00290482 <o00290482@huawei.com>
Hi, Jason
   May be my local configuration error causing the wroong author.  How should I make changes?

The correct as follows:
From: Lijun Ou <oulijun@huawei.com>
> The buffer size of qp which used to allocate qp buffer space for
> storing sqwqe and rqwqe will be the length of buffer space. The
> kernel driver will use the buffer address and the same size to
> get the user memory. The same size named buff_size of qp. According
> the algorithm of calculating, The size of the two is not equal
> when users set the max sge of sq.
>
> Fixes: b28ca7cceff8 ("RDMA/hns: Limit extend sq sge num")
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_qp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
> index 305be42..d56c03d 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_qp.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
> @@ -392,8 +392,8 @@ static int hns_roce_set_user_sq_size(struct hns_roce_dev *hr_dev,
>  					     hr_qp->sq.wqe_shift), PAGE_SIZE);
>  	} else {
>  		page_size = 1 << (hr_dev->caps.mtt_buf_pg_sz + PAGE_SHIFT);
> -		hr_qp->sge.sge_cnt =
> -		       max(page_size / (1 << hr_qp->sge.sge_shift), ex_sge_num);
> +		hr_qp->sge.sge_cnt = ex_sge_num ?
> +		   max(page_size / (1 << hr_qp->sge.sge_shift), ex_sge_num) : 0;
>  		hr_qp->buff_size = HNS_ROCE_ALOGN_UP((hr_qp->rq.wqe_cnt <<
>  					     hr_qp->rq.wqe_shift), page_size) +
>  				   HNS_ROCE_ALOGN_UP((hr_qp->sge.sge_cnt <<

Re: [PATCH for-next 5/8] RDMA/hns: Bugfix for calculating qp buffer size

[Jason Gunthorpe]

On Sat, Jul 06, 2019 at 09:47:09AM +0800, oulijun wrote:
> 在 2019/6/24 19:47, Lijun Ou 写道:
> > From: o00290482 <o00290482@huawei.com>
> Hi, Jason
>    May be my local configuration error causing the wroong author.  How should I make changes?
> 
> The correct as follows:
> From: Lijun Ou <oulijun@huawei.com>

I fixed it this once, but please check and fix it on your end in
future.

You should be able to set the patch author in git's config file:

[user]
        email = jgg@mellanox.com
        name = Jason Gunthorpe

Jason

Re: [PATCH for-next 5/8] RDMA/hns: Bugfix for calculating qp buffer size

[oulijun]

在 2019/7/7 20:21, Jason Gunthorpe 写道:
> On Sat, Jul 06, 2019 at 09:47:09AM +0800, oulijun wrote:
>> 在 2019/6/24 19:47, Lijun Ou 写道:
>>> From: o00290482 <o00290482@huawei.com>
>> Hi, Jason
>>    May be my local configuration error causing the wroong author.  How should I make changes?
>>
>> The correct as follows:
>> From: Lijun Ou <oulijun@huawei.com>
> I fixed it this once, but please check and fix it on your end in
> future.
>
> You should be able to set the patch author in git's config file:
>
> [user]
>         email = jgg@mellanox.com
>         name = Jason Gunthorpe
>
> Jason
>
> .
Thanks.