Re: [PATCH] RDMA/irdma: Move variable into switch case

[Jason Gunthorpe <jgg@ziepe.ca>]

On Thu, Feb 02, 2023 at 09:58:47AM +0200, Leon Romanovsky wrote:
> On Thu, Feb 02, 2023 at 12:09:50AM +0000, Jack Vogel wrote:
> > Hey Leon,
> > 
> > Oracle switched to GCC11 in our UEK7/OL9 releases recently, leading up to that release we added the ALL_ZERO config option, and then ran into some warnings, our build treats warnings as errors and would fail. For instance this thread: 
> > 
> > https://lkml.iu.edu/hypermail/linux/kernel/2202.1/05558.html
> > 
> > A number of changes were made in the mainline code by Kees Cook and even made it into the linux-5.15.y branch, but a couple of them we have carried as specials for the past year, I was recently prodded about the matter again by an internal group, so I thought I would submit these patches upstream. 
> > 
> > I must apologize though, for unbeknownst to me, our tools team actually back ported the fix from gcc12 regarding these warnings and forgot to tell the UEK group about it :) It wasn’t until you asked about the warnings, I reverted the commits and did a build to capture them, then I discovered they no longer occur. So, sorry about the noise. I will be reverting our own changes as unnecessary now.
> 
> Glad to hear.

Regardless, it is really weird coding style to have a variable
block immediately after the switch statement

Jason