Re: [PATCH] RDMA/irdma: Move variable into switch case

[Leon Romanovsky <leon@kernel.org>]

On Tue, Jan 31, 2023 at 05:28:23PM -0800, Jack Vogel wrote:
> Fix build warnings when CONFIG_INIT_STACK_ALL_ZERO is enabled.

Which warnings do you see? What is you compiler version?

The code is perfectly fine.

> 
> Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
> ---
>  drivers/infiniband/hw/irdma/hw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
> index ab246447520b..e3c639a0d920 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -272,8 +272,8 @@ static void irdma_process_aeq(struct irdma_pci_f *rf)
>  		}
>  
>  		switch (info->ae_id) {
> +		case IRDMA_AE_LLP_CONNECTION_ESTABLISHED: {
>  			struct irdma_cm_node *cm_node;
> -		case IRDMA_AE_LLP_CONNECTION_ESTABLISHED:
>  			cm_node = iwqp->cm_node;
>  			if (cm_node->accept_pend) {
>  				atomic_dec(&cm_node->listener->pend_accepts_cnt);
> @@ -281,7 +281,7 @@ static void irdma_process_aeq(struct irdma_pci_f *rf)
>  			}
>  			iwqp->rts_ae_rcvd = 1;
>  			wake_up_interruptible(&iwqp->waitq);
> -			break;
> +		} break;
>  		case IRDMA_AE_LLP_FIN_RECEIVED:
>  		case IRDMA_AE_RDMAP_ROE_BAD_LLP_CLOSE:
>  			if (qp->term_flags)
> -- 
> 2.39.1
>