* [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value
@ 2021-01-14 19:14 Kamal Heib
2021-01-18 17:01 ` Potnuri Bharat Teja
2021-01-19 0:17 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Heib @ 2021-01-14 19:14 UTC (permalink / raw)
To: linux-rdma; +Cc: Jason Gunthorpe, Doug Ledford, Potnuri Bharat Teja, Kamal Heib
The max_recv_sge value is wrongly reported when calling query_qp, This
is happening due to a typo when assigning the max_recv_sge value, the
value of sq_max_sges was assigned instead of rq_max_sges.
Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/hw/cxgb4/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index a7401398cb34..d109bb3822a5 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -2474,7 +2474,7 @@ int c4iw_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
init_attr->cap.max_send_wr = qhp->attr.sq_num_entries;
init_attr->cap.max_recv_wr = qhp->attr.rq_num_entries;
init_attr->cap.max_send_sge = qhp->attr.sq_max_sges;
- init_attr->cap.max_recv_sge = qhp->attr.sq_max_sges;
+ init_attr->cap.max_recv_sge = qhp->attr.rq_max_sges;
init_attr->cap.max_inline_data = T4_MAX_SEND_INLINE;
init_attr->sq_sig_type = qhp->sq_sig_all ? IB_SIGNAL_ALL_WR : 0;
return 0;
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value
2021-01-14 19:14 [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value Kamal Heib
@ 2021-01-18 17:01 ` Potnuri Bharat Teja
2021-01-19 0:17 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Potnuri Bharat Teja @ 2021-01-18 17:01 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma@vger.kernel.org, Jason Gunthorpe, Doug Ledford
On Friday, January 01/15/21, 2021 at 00:44:23 +0530, Kamal Heib wrote:
> The max_recv_sge value is wrongly reported when calling query_qp, This
> is happening due to a typo when assigning the max_recv_sge value, the
> value of sq_max_sges was assigned instead of rq_max_sges.
>
> Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
Thanks for the patch Kamal.
Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
> drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
> index a7401398cb34..d109bb3822a5 100644
> --- a/drivers/infiniband/hw/cxgb4/qp.c
> +++ b/drivers/infiniband/hw/cxgb4/qp.c
> @@ -2474,7 +2474,7 @@ int c4iw_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
> init_attr->cap.max_send_wr = qhp->attr.sq_num_entries;
> init_attr->cap.max_recv_wr = qhp->attr.rq_num_entries;
> init_attr->cap.max_send_sge = qhp->attr.sq_max_sges;
> - init_attr->cap.max_recv_sge = qhp->attr.sq_max_sges;
> + init_attr->cap.max_recv_sge = qhp->attr.rq_max_sges;
> init_attr->cap.max_inline_data = T4_MAX_SEND_INLINE;
> init_attr->sq_sig_type = qhp->sq_sig_all ? IB_SIGNAL_ALL_WR : 0;
> return 0;
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value
2021-01-14 19:14 [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value Kamal Heib
2021-01-18 17:01 ` Potnuri Bharat Teja
@ 2021-01-19 0:17 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-01-19 0:17 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Doug Ledford, Potnuri Bharat Teja
On Thu, Jan 14, 2021 at 09:14:23PM +0200, Kamal Heib wrote:
> The max_recv_sge value is wrongly reported when calling query_qp, This
> is happening due to a typo when assigning the max_recv_sge value, the
> value of sq_max_sges was assigned instead of rq_max_sges.
>
> Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
> drivers/infiniband/hw/cxgb4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-19 0:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-14 19:14 [PATCH for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value Kamal Heib
2021-01-18 17:01 ` Potnuri Bharat Teja
2021-01-19 0:17 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox