* [PATCH for-next] RDMA/hfi1: Depend on !UML
@ 2022-07-11 14:54 Dennis Dalessandro
2022-07-12 9:54 ` Leon Romanovsky
2022-07-18 10:41 ` Leon Romanovsky
0 siblings, 2 replies; 5+ messages in thread
From: Dennis Dalessandro @ 2022-07-11 14:54 UTC (permalink / raw)
To: jgg, leonro; +Cc: Ehab Ababneh, linux-rdma
From: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
Both hfi1 and UML depend on x86_64, this can trigger build errors.
This driver must depends on !UML because it accesses x86_64
features that are not supported by UML.
Signed-off-by: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
---
drivers/infiniband/hw/hfi1/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig
index 6eb739052121..14b92e12bf29 100644
--- a/drivers/infiniband/hw/hfi1/Kconfig
+++ b/drivers/infiniband/hw/hfi1/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config INFINIBAND_HFI1
tristate "Cornelis OPX Gen1 support"
- depends on X86_64 && INFINIBAND_RDMAVT && I2C
+ depends on X86_64 && INFINIBAND_RDMAVT && I2C && !UML
select MMU_NOTIFIER
select CRC32
select I2C_ALGOBIT
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH for-next] RDMA/hfi1: Depend on !UML
2022-07-11 14:54 [PATCH for-next] RDMA/hfi1: Depend on !UML Dennis Dalessandro
@ 2022-07-12 9:54 ` Leon Romanovsky
2022-07-12 12:33 ` Dennis Dalessandro
2022-07-18 10:41 ` Leon Romanovsky
1 sibling, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2022-07-12 9:54 UTC (permalink / raw)
To: Dennis Dalessandro; +Cc: jgg, Ehab Ababneh, linux-rdma
On Mon, Jul 11, 2022 at 10:54:38AM -0400, Dennis Dalessandro wrote:
> From: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
>
> Both hfi1 and UML depend on x86_64, this can trigger build errors.
> This driver must depends on !UML because it accesses x86_64
> features that are not supported by UML.
>
> Signed-off-by: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> ---
> drivers/infiniband/hw/hfi1/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)a
But why is this hfi1 specific change?
Shouldn't CONFIG_UML be disabled if someone choses !x86_64?
Thanks
>
> diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig
> index 6eb739052121..14b92e12bf29 100644
> --- a/drivers/infiniband/hw/hfi1/Kconfig
> +++ b/drivers/infiniband/hw/hfi1/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config INFINIBAND_HFI1
> tristate "Cornelis OPX Gen1 support"
> - depends on X86_64 && INFINIBAND_RDMAVT && I2C
> + depends on X86_64 && INFINIBAND_RDMAVT && I2C && !UML
> select MMU_NOTIFIER
> select CRC32
> select I2C_ALGOBIT
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-next] RDMA/hfi1: Depend on !UML
2022-07-12 9:54 ` Leon Romanovsky
@ 2022-07-12 12:33 ` Dennis Dalessandro
2022-07-13 6:57 ` Leon Romanovsky
0 siblings, 1 reply; 5+ messages in thread
From: Dennis Dalessandro @ 2022-07-12 12:33 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: jgg, Ehab Ababneh, linux-rdma
On 7/12/22 5:54 AM, Leon Romanovsky wrote:
> On Mon, Jul 11, 2022 at 10:54:38AM -0400, Dennis Dalessandro wrote:
>> From: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
>>
>> Both hfi1 and UML depend on x86_64, this can trigger build errors.
>> This driver must depends on !UML because it accesses x86_64
>> features that are not supported by UML.
>>
>> Signed-off-by: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
>> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
>> ---
>> drivers/infiniband/hw/hfi1/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)a
>
> But why is this hfi1 specific change?
> Shouldn't CONFIG_UML be disabled if someone choses !x86_64?
This was discussed in [1]. Perhaps there is further work from UML folks
warranted. However there really isn't any reason to try to compile a HW driver
like hfi1 for UML and this will silence build warnings.
1: https://lore.kernel.org/linux-rdma/20220102070623.24009-1-rdunlap@infradead.org/
-Denny
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-next] RDMA/hfi1: Depend on !UML
2022-07-12 12:33 ` Dennis Dalessandro
@ 2022-07-13 6:57 ` Leon Romanovsky
0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2022-07-13 6:57 UTC (permalink / raw)
To: Dennis Dalessandro; +Cc: jgg, Ehab Ababneh, linux-rdma
On Tue, Jul 12, 2022 at 08:33:17AM -0400, Dennis Dalessandro wrote:
> On 7/12/22 5:54 AM, Leon Romanovsky wrote:
> > On Mon, Jul 11, 2022 at 10:54:38AM -0400, Dennis Dalessandro wrote:
> >> From: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
> >>
> >> Both hfi1 and UML depend on x86_64, this can trigger build errors.
> >> This driver must depends on !UML because it accesses x86_64
> >> features that are not supported by UML.
> >>
> >> Signed-off-by: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
> >> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> >> ---
> >> drivers/infiniband/hw/hfi1/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)a
> >
> > But why is this hfi1 specific change?
> > Shouldn't CONFIG_UML be disabled if someone choses !x86_64?
>
> This was discussed in [1]. Perhaps there is further work from UML folks
> warranted. However there really isn't any reason to try to compile a HW driver
> like hfi1 for UML and this will silence build warnings.
I don't like this solution, but ok.
Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-next] RDMA/hfi1: Depend on !UML
2022-07-11 14:54 [PATCH for-next] RDMA/hfi1: Depend on !UML Dennis Dalessandro
2022-07-12 9:54 ` Leon Romanovsky
@ 2022-07-18 10:41 ` Leon Romanovsky
1 sibling, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2022-07-18 10:41 UTC (permalink / raw)
To: Dennis Dalessandro; +Cc: jgg, Ehab Ababneh, linux-rdma
On Mon, Jul 11, 2022 at 10:54:38AM -0400, Dennis Dalessandro wrote:
> From: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
>
> Both hfi1 and UML depend on x86_64, this can trigger build errors.
> This driver must depends on !UML because it accesses x86_64
> features that are not supported by UML.
>
> Signed-off-by: Ehab Ababneh <ehab.ababneh@cornelisnetworks.com>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> ---
> drivers/infiniband/hw/hfi1/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks, applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-18 10:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-11 14:54 [PATCH for-next] RDMA/hfi1: Depend on !UML Dennis Dalessandro
2022-07-12 9:54 ` Leon Romanovsky
2022-07-12 12:33 ` Dennis Dalessandro
2022-07-13 6:57 ` Leon Romanovsky
2022-07-18 10:41 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox