* [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps
@ 2022-07-11 19:21 Christophe JAILLET
2022-07-12 17:28 ` Saleem, Shiraz
2022-07-18 10:25 ` Leon Romanovsky
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-07-11 19:21 UTC (permalink / raw)
To: Mustafa Ismail, Shiraz Saleem, Jason Gunthorpe, Leon Romanovsky
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-rdma
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
It is less verbose and it improves the semantic.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/infiniband/hw/irdma/hw.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
index dd3943d22dc6..675b138e8ef0 100644
--- a/drivers/infiniband/hw/irdma/hw.c
+++ b/drivers/infiniband/hw/irdma/hw.c
@@ -1543,7 +1543,7 @@ static void irdma_del_init_mem(struct irdma_pci_f *rf)
rf->obj_mem.pa);
rf->obj_mem.va = NULL;
if (rf->rdma_ver != IRDMA_GEN_1) {
- kfree(rf->allocated_ws_nodes);
+ bitmap_free(rf->allocated_ws_nodes);
rf->allocated_ws_nodes = NULL;
}
kfree(rf->ceqlist);
@@ -1972,9 +1972,8 @@ u32 irdma_initialize_hw_rsrc(struct irdma_pci_f *rf)
u32 ret;
if (rf->rdma_ver != IRDMA_GEN_1) {
- rf->allocated_ws_nodes =
- kcalloc(BITS_TO_LONGS(IRDMA_MAX_WS_NODES),
- sizeof(unsigned long), GFP_KERNEL);
+ rf->allocated_ws_nodes = bitmap_zalloc(IRDMA_MAX_WS_NODES,
+ GFP_KERNEL);
if (!rf->allocated_ws_nodes)
return -ENOMEM;
@@ -2023,7 +2022,7 @@ u32 irdma_initialize_hw_rsrc(struct irdma_pci_f *rf)
return 0;
mem_rsrc_kzalloc_fail:
- kfree(rf->allocated_ws_nodes);
+ bitmap_free(rf->allocated_ws_nodes);
rf->allocated_ws_nodes = NULL;
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps
2022-07-11 19:21 [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps Christophe JAILLET
@ 2022-07-12 17:28 ` Saleem, Shiraz
2022-07-18 10:25 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Saleem, Shiraz @ 2022-07-12 17:28 UTC (permalink / raw)
To: Christophe JAILLET, Ismail, Mustafa, Jason Gunthorpe,
Leon Romanovsky
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-rdma@vger.kernel.org
> Subject: [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps
>
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/hw/irdma/hw.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Looks ok.
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps
2022-07-11 19:21 [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps Christophe JAILLET
2022-07-12 17:28 ` Saleem, Shiraz
@ 2022-07-18 10:25 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-07-18 10:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Mustafa Ismail, Shiraz Saleem, Jason Gunthorpe, linux-kernel,
kernel-janitors, linux-rdma
On Mon, Jul 11, 2022 at 09:21:39PM +0200, Christophe JAILLET wrote:
> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/hw/irdma/hw.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-18 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-11 19:21 [PATCH] RDMA/irdma: Use the bitmap API to allocate bitmaps Christophe JAILLET
2022-07-12 17:28 ` Saleem, Shiraz
2022-07-18 10:25 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox