* [PATCH] IB/mlx5: Call io_stop_wc() after writing to WC MMIO
@ 2022-07-29 16:33 Jason Gunthorpe
2022-08-16 12:11 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Jason Gunthorpe @ 2022-07-29 16:33 UTC (permalink / raw)
To: Leon Romanovsky, linux-rdma; +Cc: Pavel Shamis
This new function is defined only on ARM and serves to guarantee a barrier
in the WC operation. The barrier means that another run of this loop will
not combine with the stores this loop created.
On x86 this is happening implicitly because of the spin_unlock().
Suggested-by: "Pavel Shamis" <Pavel.Shamis@arm.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/infiniband/hw/mlx5/mem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/mlx5/mem.c b/drivers/infiniband/hw/mlx5/mem.c
index 6191aa833ac2b1..6b29e9ca323ea4 100644
--- a/drivers/infiniband/hw/mlx5/mem.c
+++ b/drivers/infiniband/hw/mlx5/mem.c
@@ -152,6 +152,7 @@ static int post_send_nop(struct mlx5_ib_dev *dev, struct ib_qp *ibqp, u64 wr_id,
for (i = 0; i < 8; i++)
mlx5_write64(&mmio_wqe[i * 2],
bf->bfreg->map + bf->offset + i * 8);
+ io_stop_wc();
bf->offset ^= bf->buf_size;
base-commit: dd390cba54bbd74fb675a4ac0a78dc23a20d49e2
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IB/mlx5: Call io_stop_wc() after writing to WC MMIO
2022-07-29 16:33 [PATCH] IB/mlx5: Call io_stop_wc() after writing to WC MMIO Jason Gunthorpe
@ 2022-08-16 12:11 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-08-16 12:11 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma, Pavel Shamis
On Fri, Jul 29, 2022 at 01:33:38PM -0300, Jason Gunthorpe wrote:
> This new function is defined only on ARM and serves to guarantee a barrier
> in the WC operation. The barrier means that another run of this loop will
> not combine with the stores this loop created.
>
> On x86 this is happening implicitly because of the spin_unlock().
>
> Suggested-by: "Pavel Shamis" <Pavel.Shamis@arm.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/mem.c | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-29 16:33 [PATCH] IB/mlx5: Call io_stop_wc() after writing to WC MMIO Jason Gunthorpe
2022-08-16 12:11 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox